Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Setting invoker package name for AbstractScalaCodegen #9378

Closed
sandeepjindal opened this issue May 1, 2021 · 1 comment
Closed

[REQ] Setting invoker package name for AbstractScalaCodegen #9378

sandeepjindal opened this issue May 1, 2021 · 1 comment

Comments

@sandeepjindal
Copy link
Contributor

sandeepjindal commented May 1, 2021

Not able to set the invoker package name from additionalproperties in ScalaHttpClientCodegen

In ScalaHttpCodegen the setting of INVOKER_PACKAGE is missing in processOpts()

        if (additionalProperties.containsKey(CodegenConstants.INVOKER_PACKAGE)) {
            this.setInvokerPackage((String) additionalProperties.get(CodegenConstants.INVOKER_PACKAGE));
        }

Because of the when we do codegen it always fallback to default value.

Solution

We can add something like this

if (additionalProperties.containsKey(CodegenConstants.INVOKER_PACKAGE)) {

in AbstractScalaCode:

Please feel free to ask more in case more context is needed.
I have opened the PR for the same.
#9381

@sandeepjindal
Copy link
Contributor Author

This is already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant