Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elm] enum items and parameters #5051

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

eriktim
Copy link
Contributor

@eriktim eriktim commented Jan 20, 2020

  • drop unused tests;
  • fix encoders/decoders for list of enumerations;
  • add suffix to parameter names so that they do not conflict with (1) each other and (2) the operation name

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@eriktim eriktim added this to the 5.0.0 milestone Jan 20, 2020
@eriktim eriktim changed the title Elm enum items and parameters [elm] enum items and parameters Jan 20, 2020
@eriktim eriktim force-pushed the elm-enum-items-and-parameters branch from 462146c to 3dd23ba Compare January 20, 2020 09:38
So there are no longer conflicts between parameters or
parameters and operation names.
@eriktim eriktim force-pushed the elm-enum-items-and-parameters branch from 3dd23ba to 51f0182 Compare January 20, 2020 19:08
@eriktim eriktim merged commit 71128f7 into OpenAPITools:5.0.x Jan 23, 2020
@eriktim eriktim deleted the elm-enum-items-and-parameters branch January 23, 2020 12:13
jimschubert added a commit that referenced this pull request Jan 26, 2020
* 5.0.x: (92 commits)
  [Rust Server] Handle array of objects inside an object correctly (#5044)
  [Rust Server] Sanitise enum values (#5042)
  [Rust Server] Add support for primitive arrays (#5041)
  [elm] Fix duplicate coder names (#5100)
  [elm] enum items and parameters (#5051)
  [elm] Fix decoding empty operation responses (#5055)
  resolve merge conflicts in VERSION files
  undo restoring ElmClientCodegenTest.java
  fix merge conflicts
  [dart-dio] Various fixes (#5027)
  Add java code comments based on explanation from Jim Schubert (#5048)
  Execute ./bin/openapi3/go-experimental-petstore.sh script (#5049)
  [docs] Sorted doc outputs and clean up duplicated CliOptions (#5046)
  Add docs/installation.md and docsite index to version update script (#5037)
  [gradle] consistent use of maven url in gradle files (#5045)
  Use HTTPS Maven URL in Kotlin meta generator (#5043)
  [Python] fix numeric enum in python flask, aiohttp (#5019)
  add multipleOf to various codegen classes (#5021)
  Add a link to a youtube video on Pulp and OpenAPI Generator (#5038)
  [scripts] Remove misspelled OPENAPI_GENERATOR_DOWLOAD_CACHE_DIR (#5035)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant