Use HTTPS Maven URL in Kotlin meta generator #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continues on work in OpenAPITools#5033 and OpenAPITools#5034 which convert all http usage to https to unblock CircleCI builds. In OpenAPITools#5034, mavenCentral() DSL was updated to explicitly target the https maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of our examples use earlier versions of Gradle. The Kotlin meta generator was missed because it is a .kts build file rather than build.gradle, and the mustache filename doesn't have kts in it; the file was updated as if it was build.gradle (groovy syntax).
5 tasks
wing328
approved these changes
Jan 19, 2020
jimschubert
added a commit
that referenced
this pull request
Jan 26, 2020
* 5.0.x: (92 commits) [Rust Server] Handle array of objects inside an object correctly (#5044) [Rust Server] Sanitise enum values (#5042) [Rust Server] Add support for primitive arrays (#5041) [elm] Fix duplicate coder names (#5100) [elm] enum items and parameters (#5051) [elm] Fix decoding empty operation responses (#5055) resolve merge conflicts in VERSION files undo restoring ElmClientCodegenTest.java fix merge conflicts [dart-dio] Various fixes (#5027) Add java code comments based on explanation from Jim Schubert (#5048) Execute ./bin/openapi3/go-experimental-petstore.sh script (#5049) [docs] Sorted doc outputs and clean up duplicated CliOptions (#5046) Add docs/installation.md and docsite index to version update script (#5037) [gradle] consistent use of maven url in gradle files (#5045) Use HTTPS Maven URL in Kotlin meta generator (#5043) [Python] fix numeric enum in python flask, aiohttp (#5019) add multipleOf to various codegen classes (#5021) Add a link to a youtube video on Pulp and OpenAPI Generator (#5038) [scripts] Remove misspelled OPENAPI_GENERATOR_DOWLOAD_CACHE_DIR (#5035) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on work in #5033 and #5034 which convert all http usage
to https to unblock CircleCI builds.
In #5034, mavenCentral() DSL was updated to explicitly target the https
maven repo because Gradle didn't force TLS 1.2 until v4.8.1 and many of
our examples use earlier versions of Gradle. The Kotlin meta generator
was missed because it is a .kts build file rather than build.gradle, and
the mustache filename doesn't have kts in it; the file was updated as if
it was build.gradle (groovy syntax).
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.