Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quantiles #278, add statistics category #277 #294

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Oct 26, 2021

First draft for #277 and #278.

Still to do (open for suggestions):

  • Wording around probabilities. This is general statistical language and is potentially useful to define, but @soxofann raises that this is not really fitting here.
  • Check whether we also want to implement quantiles: Unify probabilities and q #293 (deprecate parameter probabilities, unify to parameter q) -> separate PR

@m-mohr m-mohr added the patch label Oct 26, 2021
@m-mohr m-mohr added this to the 1.2.0 milestone Oct 26, 2021
@m-mohr m-mohr requested review from soxofaan and edzer October 26, 2021 12:21
@m-mohr m-mohr self-assigned this Oct 26, 2021
This was linked to issues Oct 26, 2021
quantiles.json Outdated Show resolved Hide resolved
@soxofaan
Copy link
Member

Related: while looking up example definitions and descriptions I stumbled on this:
https://blogs.sas.com/content/iml/2017/05/24/definitions-sample-quantiles.html referencing https://www.amherst.edu/media/view/129116/original/Sample+Quantiles.pdf

there are nine definitions of sample quantiles that commonly appear in statistical software packages.

If we want consistency across backends, we probably have to pick which flavor of "sample quantiles" we want.

at the moment I have no idea which flavor that's currently used in VITO/EODC backends for example

@m-mohr
Copy link
Member Author

m-mohr commented Oct 27, 2021

Ouch, that's painful. So we should probably asses which implementations we currently have, otherwise a useful process description is impossible. Doesn't help if we enforce a type that's not implemented anywhere. Anyway, this is something for a separate issue and I'll continue with these changes anyway.

Edit: New issue is #296

@m-mohr m-mohr mentioned this pull request Oct 27, 2021
@m-mohr m-mohr marked this pull request as ready for review October 27, 2021 11:40
@m-mohr m-mohr merged commit c17e7e9 into draft Oct 27, 2021
@m-mohr m-mohr deleted the issues-277-278 branch October 27, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

q param in quantiles add "statistics" category to quantiles
2 participants