-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "statistics" category to quantiles
#277
Comments
Hmm, I'm not sure I agree. This would make it less clear what a reducer strictly is. It would not just be quantiles, too, as there are more similar processes, e.g. Looking at the reducers right now, I'd even argue listing the |
I guess it depends on what a "category" means to you, To me, the categories are just thematic labels to help with finding processes you need for a particular use case. In case of quantiles: because Other approach: change category |
Those are labels, but they should still be somewhat consistently chosen. So we'd need to add them not just to quantiles, but also to extrema. I'm just trying to avoid that someone simply tries to use quantiles exactly as e.g. mean and then it fails. The docs refer to reducers and say that you can use them, but in the quantiles/extrema/... cases it's not as simple... |
But then Other solution: can't we also define a category "statistics" , to list these reduce/summary processes like median, mean, min, max, extrema, quantiles, ... |
Yes, that sounds like a good solution, I think. |
Meta question: can we label this ticket with something like "low-hanging-fruit" or "beginner-material" so that aspiring contributors can easily find simple issues to start working on. e.g. for python client I started using "low hanging fruit": https://github.com/Open-EO/openeo-python-client/issues?q=is%3Aissue+is%3Aopen+label%3A%22low+hanging+fruit%22 |
I've re-added the "good first issue" label, which is common on GitHub. |
quantiles
quantiles
PR is available for review: #294 |
openeo-processes/quantiles.json
Lines 2 to 7 in 60fb5e2
Strictly speaking,
quantiles
can not be used directly as a reducer (you need an additionalarray_element
to get a scalar value from its output array), but I think it makes sense to add it to the "reducer" category because it will be used often in reduce contexts.The text was updated successfully, but these errors were encountered: