Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Easy Netplay when starting through Search #1541

Merged
merged 1 commit into from
May 9, 2024

Conversation

XK9274
Copy link
Member

@XK9274 XK9274 commented Apr 8, 2024

EN is failing to launch RetroArch as it retrieves the wrong path from GLO.

[INFO] [Content]: Loading content file: "/mnt/SDCARD/Emu/GB/launch.sh:/mnt/SDCARD/Emu/GB/../../Roms/GB/Balloon Kid (USA, Europe).zip".
[ERROR] [Content]: Could not read content file "/mnt/SDCARD/Emu/GB/launch.sh:/mnt/SDCARD/Emu/GB/../../Roms/GB/Balloon Kid (USA, Europe).zip"

This PR will fix the path passed into RetroArch and resolves: #1461 pending validation on review.

To reproduce:
Follow the instructions in the Issue, to reiterate:

  • Launch Search,
  • Search for a netplay capable Rom (Balloon kid is a good choice)
  • Open GLO
  • Open Netplay, start Easy Netplay (Hotspot)
  • Observe instant failure

Add script and re-follow instructions, now working.

@XK9274 XK9274 linked an issue Apr 8, 2024 that may be closed by this pull request
3 tasks
@XK9274 XK9274 self-assigned this Apr 8, 2024
@XK9274 XK9274 added the bug in onion Something isn't working label Apr 8, 2024
@XK9274 XK9274 added this to the v4.4 milestone Apr 8, 2024
@XK9274
Copy link
Member Author

XK9274 commented Apr 9, 2024

Tested by a community member here:

https://www.reddit.com/r/MiyooMini/s/85KBwQnwkv

@XK9274 XK9274 requested a review from schmurtzm April 9, 2024 20:53
@Aemiii91 Aemiii91 added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit ac64abc May 9, 2024
1 check passed
@Aemiii91 Aemiii91 deleted the fix-easy-netplay-search branch May 9, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug in onion Something isn't working
Projects
Status: Done / Ready for release
Development

Successfully merging this pull request may close these issues.

Easy Netplay using GLO after a search doesn't launch
2 participants