Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easy Netplay using GLO after a search doesn't launch #1461

Closed
3 tasks done
XDarkBringX opened this issue Mar 2, 2024 · 1 comment · Fixed by #1541
Closed
3 tasks done

Easy Netplay using GLO after a search doesn't launch #1461

XDarkBringX opened this issue Mar 2, 2024 · 1 comment · Fixed by #1541

Comments

@XDarkBringX
Copy link

Checklist

  • I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
  • I have reviewed the Onion Docs and did not find the answer
  • I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

MM+ on 4.2.3 and 4.3

Miyoo Firmware Version

202303292051

Provide a clear and concise description of the issue

I used the search feature to look up a game and try to launch GLO easy netplay after selecting a game. When it says creating hotspot, right after it just says cleaning up and boots me back to game selection. I tried it with a few games (contra 3, Super Mario bro 3, Mortal Kombat 3) using the search and all fail, but when I manual go into SNES folder and scroll to those games and GLO easy netplay it works.

Steps to Reproduce

Use search feature
select a netplay-able game
GLO easy netplay
it attempts to create hotspots but gets booted

Provide any additional context or information that may help us investigate your issue

hosting a standard netplay through search feature works.
@XK9274 XK9274 mentioned this issue Apr 8, 2024
Merged
@XK9274 XK9274 linked a pull request Apr 8, 2024 that will close this issue
Fix Easy Netplay when starting through Search #1541
Merged
@XK9274
Copy link
Member

XK9274 commented Apr 8, 2024 •
edited
Loading

This will be fixed (and the issue closed) when #1541 merges - thanks for letting us know

github-merge-queue bot pushed a commit that referenced this issue May 9, 2024
@XK9274
Fix Easy Netplay when starting through Search (#1541)
ac64abc 
EN is failing to launch RetroArch as it retrieves the wrong path from
GLO.

```
[INFO] [Content]: Loading content file: "/mnt/SDCARD/Emu/GB/launch.sh:/mnt/SDCARD/Emu/GB/../../Roms/GB/Balloon Kid (USA, Europe).zip".
[ERROR] [Content]: Could not read content file "/mnt/SDCARD/Emu/GB/launch.sh:/mnt/SDCARD/Emu/GB/../../Roms/GB/Balloon Kid (USA, Europe).zip"
```

This PR will fix the path passed into RetroArch and resolves: #1461
pending validation on review.

To reproduce:
Follow the instructions in the Issue, to reiterate:

- Launch Search, 
- Search for a netplay capable Rom (Balloon kid is a good choice)
- Open GLO
- Open Netplay, start Easy Netplay (Hotspot)
- Observe instant failure

Add script and re-follow instructions, now working.
belmix added a commit to belmix/OnionRV that referenced this issue Jun 19, 2024
@belmix
Fix Easy Netplay when starting through Search
84e93d3 
EN is failing to launch RetroArch as it retrieves the wrong path from
GLO.

```
[INFO] [Content]: Loading content file: "/mnt/SDCARD/Emu/GB/launch.sh:/mnt/SDCARD/Emu/GB/../../Roms/GB/Balloon Kid (USA, Europe).zip".
[ERROR] [Content]: Could not read content file "/mnt/SDCARD/Emu/GB/launch.sh:/mnt/SDCARD/Emu/GB/../../Roms/GB/Balloon Kid (USA, Europe).zip"
```

This PR will fix the path passed into RetroArch and resolves: OnionUI#1461
pending validation on review.

To reproduce:
Follow the instructions in the Issue, to reiterate:

- Launch Search,
- Search for a netplay capable Rom (Balloon kid is a good choice)
- Open GLO
- Open Netplay, start Easy Netplay (Hotspot)
- Observe instant failure

Add script and re-follow instructions, now working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Easy Netplay when starting through Search OnionUI/Onion
2 participants
@XK9274 @XDarkBringX