-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Spools in UI on API call #28
Conversation
This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days. |
@OllisGit Any chance you want to take a look before Mr. Stale closes my request? |
Hi @oschwartz10612 , thanks for the PR. I would like to implement your PR with a small change. Instead of the keyword What do you think? PS. Sorry, for being late to the party, but I made a "Octoprint sabatical" (no coding, no printing) the last months. |
Hi! No problem, it is important to take breaks! I think you are correct. Is there anything else you would like to see changed? Thanks for your work on the project! |
Hi @oschwartz10612, |
I believe I fixed the conflict. Let me know if it is unsatisfactory. |
- MR #15 inform external ui (like OctoDash) about filament change. Credit goes to @gdombiak - MR #28 creating and selecting a spool via API. Credit goes to @oschwartz10612
- MR #15 inform external ui (like OctoDash) about filament change. Credit goes to @gdombiak - MR #28 creating and selecting a spool via API. Credit goes to @oschwartz10612
Release 1.7.0 is out. |
Allows a client to update the ui when inserting or selecting spools. Previously a reload of the page was required.
Example api call:
The
update:True
is required to prevent normal calls from unnecessarily updating.I am using this in my project here to update spools when scanned with a barcode scanner.