Send plugin notification when user selects new spool from UI #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days. |
stale
bot
added
the
status: markedForAutoClose
|
Hi @OllisGit, pinging you before the bot decides to close this PR! :) |
stale
bot
removed
the
status: markedForAutoClose
|
This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days. |
stale
bot
added
the
status: markedForAutoClose
|
Hi @OllisGit, last try to keep this PR alive before the "evil" bot :) closes it for me! :) |
stale
bot
removed
the
status: markedForAutoClose
OllisGit
changed the base branch from
master
to
feature/15-spool-selection-notification
OllisGit
changed the base branch from
feature/15-spool-selection-notification
to
master
|
Sorry, for being late to the party, but I made a "Octoprint sabatical" (no coding, no printing) the last months. MR is merged and will be in the next release! |
OllisGit
added
status: inNextRelease
OllisGit
added a commit
that referenced
this pull request
Jan 28, 2021
- MR #15 inform external ui (like OctoDash) about filament change. Credit goes to @gdombiak - MR #28 creating and selecting a spool via API. Credit goes to @oschwartz10612
OllisGit
added a commit
that referenced
this pull request
Jan 28, 2021
- MR #15 inform external ui (like OctoDash) about filament change. Credit goes to @gdombiak - MR #28 creating and selecting a spool via API. Credit goes to @oschwartz10612
OllisGit
removed
the
status: inNextRelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OctoPod app has support for this plugin. Noticed that plugin was not sending a websocket notification when selecting a spool. This PR adds this notification