Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add challenge36: Advanced reverse engineering game #947

Merged
merged 36 commits into from
Oct 2, 2023

Conversation

roddas
Copy link
Contributor

@roddas roddas commented Aug 27, 2023

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Relations

Closes #617

References

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roddas ! I really really love this PR! It is awesome! I have to test it locally and there are some changes requested, but overall it looks promising.
Can you please:

  • fix the feedback
  • Fix the breaking pr workflows if possible (please first sync your fork and merge master in)
  • Signal us when you are done so we can do another review round please?

@commjoen commjoen changed the title Advanced game Add challenge36: Advanced reverse engineering game Aug 29, 2023
@commjoen commjoen marked this pull request as draft September 27, 2023 14:50
@commjoen
Copy link
Collaborator

Elligible for hacktoberfest-accepted label if timely finished in october

@commjoen
Copy link
Collaborator

commjoen commented Oct 2, 2023

@roddas can you please add the last missing script so we can finish the textual revision of the hints block and merge ^^?

@roddas
Copy link
Contributor Author

roddas commented Oct 2, 2023

@roddas can you please add the last missing script so we can finish the textual revision of the hints block and merge ^^?

Which script are you referring to?

@roddas
Copy link
Contributor Author

roddas commented Oct 2, 2023

@commjoen I added the decrypt.zip file in directory src/main/resources/executables/decrypt , but the git didn't catch it.

@commjoen commjoen marked this pull request as ready for review October 2, 2023 13:40
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @roddas ! I really love this challenge! Waiting @bendehaan for the rest of the textual review so we can merge :) !

@commjoen commjoen requested a review from bendehaan October 2, 2023 13:52
@commjoen commjoen merged commit 567c572 into OWASP:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Challenge: Have advanced challenge for c/c++
3 participants