-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add challenge36: Advanced reverse engineering game #947
Conversation
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge36.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roddas ! I really really love this PR! It is awesome! I have to test it locally and there are some changes requested, but overall it looks promising.
Can you please:
- fix the feedback
- Fix the breaking pr workflows if possible (please first sync your fork and merge master in)
- Signal us when you are done so we can do another review round please?
src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge36.java
Outdated
Show resolved
Hide resolved
Elligible for |
@roddas can you please add the last missing script so we can finish the textual revision of the hints block and merge ^^? |
Co-authored-by: Ben de Haan <[email protected]>
Co-authored-by: Ben de Haan <[email protected]>
Which script are you referring to? |
@commjoen I added the decrypt.zip file in directory src/main/resources/executables/decrypt , but the git didn't catch it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @roddas ! I really love this challenge! Waiting @bendehaan for the rest of the textual review so we can merge :) !
What kind of changes does this PR include?
Description
Relations
Closes #617
References
Checklist: