Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Challenge: Have advanced challenge for c/c++ #617

Closed
2 tasks done
commjoen opened this issue Feb 13, 2023 · 4 comments · Fixed by #947
Closed
2 tasks done

New Challenge: Have advanced challenge for c/c++ #617

commjoen opened this issue Feb 13, 2023 · 4 comments · Fixed by #947
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed New Challenge Adding a new Challenge

Comments

@commjoen
Copy link
Collaborator

commjoen commented Feb 13, 2023

Based on OWASP/wrongsecrets-binaries#11 :

  • Create the new binaries for C and C++
  • Create new documentation and embed the binaries
@commjoen commjoen changed the title Have advanced challenge for c/c++ New Challenge: Have advanced challenge for c/c++ Feb 13, 2023
@commjoen commjoen added New Challenge Adding a new Challenge help wanted Extra attention is needed labels Feb 13, 2023
@commjoen commjoen added the good first issue Good for newcomers label Mar 2, 2023
@commjoen commjoen assigned commjoen and unassigned commjoen Aug 18, 2023
@commjoen
Copy link
Collaborator Author

commjoen commented Aug 18, 2023

@roddas will pick this up for the advanced C challenge :)

@roddas
Copy link
Contributor

roddas commented Aug 18, 2023

In this issue, I should only upload the binaries, right?

Can you give me some example of documentation please?

@commjoen
Copy link
Collaborator Author

Yes, you can upload the binaries and create a challenge around them :-)
So steps would be:

  1. follow https://github.com/OWASP/wrongsecrets/blob/master/CONTRIBUTING.md#how-to-add-a-challenge to setup the new challenge (including unit tests in the end)
  2. copy the new executables to src/main/resources/executables (see https://github.com/OWASP/wrongsecrets/tree/master/src/main/resources/executables) make sure they have a name that is consistent, like wrongsecrets-advanced-c, wrongsecrets-advanced-c-arm , wrongsecrets-advanced-c-linux , wrongsecrets-advanced-c-linux-arm , wrongsecrets-advanced-c-musl , wrongsecrets-advanced-c-musl-arm ,wrongsecrets-advanced-c , wrongsecrets-advanced-c-windows
  3. make sure your challenge uses the BinaryExecutionHelper, like in https://github.com/OWASP/wrongsecrets/blob/master/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge19.java#L28 and https://github.com/OWASP/wrongsecrets/blob/master/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge19.java#L45 and https://github.com/OWASP/wrongsecrets/blob/master/src/main/java/org/owasp/wrongsecrets/challenges/docker/Challenge19.java#L39 as you can see: you don't need to capture an answer in Java source code, instead, the java app will call your executable 😉

@roddas
Copy link
Contributor

roddas commented Aug 18, 2023

Thanks .

roddas added a commit to roddas/wrongsecrets that referenced this issue Aug 27, 2023
roddas added a commit to roddas/wrongsecrets that referenced this issue Aug 27, 2023
roddas added a commit to roddas/wrongsecrets that referenced this issue Aug 27, 2023
roddas added a commit to roddas/wrongsecrets that referenced this issue Aug 27, 2023
roddas added a commit to roddas/wrongsecrets that referenced this issue Aug 27, 2023
roddas added a commit to roddas/wrongsecrets that referenced this issue Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed New Challenge Adding a new Challenge
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants