docker: CI update and simplification #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While the main branch of GRASS GIS is fairly stable, I think it is more expected that it is the latest release rather than the latest state of the code. |
|
Updated workflow to build and push |
|
@wenzeslaus I updated the file according to your suggestion. Do you agree now? |
neteler
approved these changes
Aug 16, 2023
wenzeslaus
requested changes
Aug 17, 2023
There was a problem hiding this comment.
I appreciate that this is much shorter. The need to understand the many options of docker/metadata-action is unfortunate, but seem like a better alternative to the long custom code.
I'm still unclear about how some of the cases will work out here. I left individual comments for that.
wenzeslaus
approved these changes
Aug 18, 2023
|
Great work, I take liberty to merge it and backport now. |
neteler
pushed a commit
that referenced
this pull request
Aug 18, 2023
* simplify docker gh workflow (see PR for details)
neteler
pushed a commit
that referenced
this pull request
Aug 18, 2023
* simplify docker gh workflow (see PR for details)
landam
pushed a commit
to landam/grass
that referenced
this pull request
Oct 25, 2023
* simplify docker gh workflow (see PR for details)
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
* simplify docker gh workflow (see PR for details)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!! Description updated to reflect merged status after discussions!!
This PR simplifies the github workflow for docker build, tag and push.
Due to some tag restructuring and new features of docker/metadata-action it now only uses one job and, depending on the trigger action, creates different tags. It will create four different types of tags:
latestfor latest release (at this time 8.3) and with ubuntu oscurrent-{{ os }}for a still hard-coded branch, here update to releasebranch_8_3, e.gcurrent-ubuntu{{ branch }}-{{ os }}for all configured branches, e.g.releasebranch_8_3-alpine,main-debian{{ tag }}-{{ os }}for all published releases. e.g.8.3.0-alpineThis new naming conforms more with the GRASS GIS naming style of versions. While naming of branches and tags is still the same, it adds
current-{{ os }}and abandons former naming style withlatest-{{ os }}andstable-{{ os }}likelatest-alpineandstable-alpineto avoid confusion. Also content oflatesttag was changed frommainbranch to latest release.The plainlatesttag is still created because it is default fordocker pull osgeo/grass-gisand would be nice to have, although usage of it is not recommended. No strong opinion if it should point tomainbranch orreleasebranch_8_3. Open for discussion. See also OSGeo/grass-website#371As the action was triggered twice for a release,
on: [tags ](tags: ['*.*.*'])was outcommented.Whole thing was tested as can be seen in first commit of this PR on a branch named
docker-workflow-updatewith mmacata remote and dockerhub account. Created and pushed image tags can be seen here on dockerhub.