Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

news: GRASS GIS docker images moved to OSGeo org #383

Merged
merged 7 commits into from
Sep 2, 2023

Conversation

neteler
Copy link
Member

@neteler neteler commented Aug 27, 2023

GRASS GIS docker images moved from mundialis to OSGeo dockerhub organization.

Co-Authored-By: @mmacata

GRASS GIS docker images moved from mundialis to OSGeo dockerhub organization
@neteler neteler added the news News related label Aug 27, 2023
@neteler neteler self-assigned this Aug 27, 2023
Copy link
Contributor

@veroandreo veroandreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments here and there

content/news/2023_08_27_GRASS_GIS_docker_organization.md Outdated Show resolved Hide resolved
content/news/2023_08_27_GRASS_GIS_docker_organization.md Outdated Show resolved Hide resolved
content/news/2023_08_27_GRASS_GIS_docker_organization.md Outdated Show resolved Hide resolved
content/news/2023_08_27_GRASS_GIS_docker_organization.md Outdated Show resolved Hide resolved
content/news/2023_08_27_GRASS_GIS_docker_organization.md Outdated Show resolved Hide resolved
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to consistently write Docker with an uppercase D. All lowercase is just the command on command line.

@neteler
Copy link
Member Author

neteler commented Aug 28, 2023

I suggest to consistently write Docker with an uppercase D. All lowercase is just the command on command line.

Sure, done in 135a2fe

Comment on lines +36 to +41
This migration is not just a change of repository location. The move to
the OSGeo repository has been accompanied by a systematic clean-up and
reorganisation of the tags associated with the GRASS GIS Docker images.
This restructuring is intended to improve clarity, streamline
versioning and optimise the user experience when selecting appropriate
image tags for deployment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected either a summary of changes or the actions needed to react to this change, or a link to where it is explained.

For example, it could be that now we recommend using osgeo/grass-gis:xxxxx tag for most users, and osgeo/grass-gis:yyyy tag for others to pin a specific version.

Or it could be a suggestion based on the tag used before and the new tag series that should be mapped to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean to add a kind of lookup table?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be more simple than that, but at least to answer the question: As a user of the old images, what should I do to use the new organisation and tags?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps @mmacata can assist here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What has been decided finally for the meaning of :latest tag? Is it the latest release or it is a beta state/main branch/dev version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that with that PR, the existing latest tag wasn't replaced since the PR was merged on August 18 2023, and the tag 8.3.0 was created on June 24 2023.
The :latest tag will point to the code that was from the greatest released git tag (even if a backport was made later, since the workflow will be changed at each release) (ubuntu). Since there are some tags published by branch, the releasebranch_8_3-ubuntu and current-ubuntu tags will be newer than latest.
The releasebranch_8_3-ubuntu and current-ubuntu and the others with another OS suffix are published as soon as a commit is made in a release branch, before a tag/release is made, thus they represent more like a development version. backport commits in a releasebranch will immediately be available in their branch-based tag, like releasebranch_8_2-debian, before a backported release is made.

So, the tags that are really stable and match the releases are only the ones based on the GitHub tags, that should come out as "8.3.0-ubuntu, "8.3.0-debian", "8.3.0-alpine", "8.3.0-ubuntu_wxgui".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking for this, I observed that the 7.8.8 release on GitHub is marked as the "latest" release for GitHub, while it should have stayed 8.3.0, as 7.8.8 was a backport. It should be possible to go to the 8.3.0 release, edit it, and check the "Set as the latest release" checkbox even if it was older.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While looking for this, I observed that the 7.8.8 release on GitHub is marked as the "latest" release for GitHub, while it should have stayed 8.3.0, as 7.8.8 was a backport.

Ouch. Fixed (8.3.0 is again latest).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a more detailed description as suggestion below which should make it more easy to decide how to migrate.
I am not sure if the language fits because some text was a copy & paste from the PR description 🙃

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this new part now looks like this:

image

@neteler
Copy link
Member Author

neteler commented Aug 31, 2023

Are we good with the current PR?

@neteler neteler merged commit c7e277b into OSGeo:master Sep 2, 2023
@neteler neteler deleted the grass-docker_repo_moved branch September 2, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
news News related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants