-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
news: GRASS GIS docker images moved to OSGeo org #383
Conversation
GRASS GIS docker images moved from mundialis to OSGeo dockerhub organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments here and there
Co-authored-by: Veronica Andreo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to consistently write Docker with an uppercase D. All lowercase is just the command on command line.
Sure, done in 135a2fe |
This migration is not just a change of repository location. The move to | ||
the OSGeo repository has been accompanied by a systematic clean-up and | ||
reorganisation of the tags associated with the GRASS GIS Docker images. | ||
This restructuring is intended to improve clarity, streamline | ||
versioning and optimise the user experience when selecting appropriate | ||
image tags for deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected either a summary of changes or the actions needed to react to this change, or a link to where it is explained.
For example, it could be that now we recommend using osgeo/grass-gis:xxxxx tag for most users, and osgeo/grass-gis:yyyy tag for others to pin a specific version.
Or it could be a suggestion based on the tag used before and the new tag series that should be mapped to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean to add a kind of lookup table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be more simple than that, but at least to answer the question: As a user of the old images, what should I do to use the new organisation and tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps @mmacata can assist here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What has been decided finally for the meaning of :latest tag? Is it the latest release or it is a beta state/main branch/dev version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that with that PR, the existing latest tag wasn't replaced since the PR was merged on August 18 2023, and the tag 8.3.0 was created on June 24 2023.
The :latest tag will point to the code that was from the greatest released git tag (even if a backport was made later, since the workflow will be changed at each release) (ubuntu). Since there are some tags published by branch, the releasebranch_8_3-ubuntu and current-ubuntu tags will be newer than latest.
The releasebranch_8_3-ubuntu and current-ubuntu and the others with another OS suffix are published as soon as a commit is made in a release branch, before a tag/release is made, thus they represent more like a development version. backport commits in a releasebranch will immediately be available in their branch-based tag, like releasebranch_8_2-debian, before a backported release is made.
So, the tags that are really stable and match the releases are only the ones based on the GitHub tags, that should come out as "8.3.0-ubuntu, "8.3.0-debian", "8.3.0-alpine", "8.3.0-ubuntu_wxgui".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While looking for this, I observed that the 7.8.8 release on GitHub is marked as the "latest" release for GitHub, while it should have stayed 8.3.0, as 7.8.8 was a backport. It should be possible to go to the 8.3.0 release, edit it, and check the "Set as the latest release" checkbox even if it was older.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While looking for this, I observed that the 7.8.8 release on GitHub is marked as the "latest" release for GitHub, while it should have stayed 8.3.0, as 7.8.8 was a backport.
Ouch. Fixed (8.3.0 is again latest).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a more detailed description as suggestion below which should make it more easy to decide how to migrate.
I am not sure if the language fits because some text was a copy & paste from the PR description 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Carmen Tawalika <[email protected]>
Are we good with the current PR? |
GRASS GIS docker images moved from mundialis to OSGeo dockerhub organization.
Co-Authored-By: @mmacata