OilPvtThermal: encapsulate EclipseState w/ friends #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akva2
force-pushed
the
oilpvtthermal_encapsulate
branch
from
6987915 to
4863b96
Compare
thus encapsulating EclipseState and TableManager
this is user-provided data. instead throw exceptions. also replace a naked throw with OPM_THROW
this operator is not really used and will be removed later. for now just remove the problematic comparison
akva2
force-pushed
the
oilpvtthermal_encapsulate
branch
from
4863b96 to
d660b0d
Compare
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And replace assert on user-provided data with exceptions.
Sits on top of #3249
Waiting for #3246