Some small fixes in material classes #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
Strange. If a function name is changed, shouldn't there be a corresponding change somewhere where the function is called. |
|
I tried to explain that. The function is only used in templates. These templates are not currently instanced, and thus the error goes undetected. The existing call sites use the fixed method name. |
no such method
akva2
force-pushed
the
small_material_fixes
branch
from
daffcb4 to
3b7c68b
Compare
|
jenkins build this please |
This was referenced Dec 13, 2022
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the two latter have been harmless since code using them has never been instanced, but i'm working on changes that does so.
Waiting for #3246