Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM v1 release code #207

Merged
merged 4 commits into from
Mar 6, 2019
Merged

OSM v1 release code #207

merged 4 commits into from
Mar 6, 2019

Conversation

Alexdavv
Copy link
Member

@Alexdavv Alexdavv commented Mar 4, 2019

No description provided.

@aostropolets aostropolets requested review from cgreich and hardhouse and removed request for cgreich and hardhouse March 4, 2019 15:32
@cgreich
Copy link
Contributor

cgreich commented Mar 4, 2019

Where can I see the data in dev?

@Alexdavv
Copy link
Member Author

Alexdavv commented Mar 5, 2019

In dev_osm schema

@pavgra
Copy link

pavgra commented Mar 5, 2019

What about polygons for the areas? Will there be a coupled CSV / any other data file with concept_id / concept code and geom pairs?

@Alexdavv
Copy link
Member Author

Alexdavv commented Mar 5, 2019

What about polygons for the areas? Will there be a coupled CSV / any other data file with concept_id / concept code and geom pairs?

@pavgra Sure, concept_code + geometry is already in the used source and csv may be exported now. Once vocabulary is released, the concept_id + geometry pairs will be available as well.

@pavgra
Copy link

pavgra commented Mar 5, 2019

The reason I'm asking:

  • I do not see where geom field is persisted into resulting (stage?) table
  • not sure how that would be processed via Athena, we haven't discussed any solutions yet

@Alexdavv
Copy link
Member Author

Alexdavv commented Mar 5, 2019

  • I do not see where geom field is persisted into resulting (stage?) table

It's non needed there now since CDM is not ready for storing the geom data.

  • not sure how that would be processed via Athena, we haven't discussed any solutions yet

Ok, good. We`re ready to discuss with Athena developers.

@pavgra
Copy link

pavgra commented Mar 5, 2019

It's non needed there now since CDM is not ready for storing the geom data.

From what I recap (OHDSI/CommonDataModel#220 (comment)), it was decided not to store any binary data (polygons) in CDM. Plus, the data is required for separate apps / ETL, not for the CDM itself (the CDM itself will contain precomputed links and relations of entities from medical to geo domains). Therefore, not sure what you are waiting for.

@cgreich
Copy link
Contributor

cgreich commented Mar 5, 2019

Not sure what you guys are debating. Now that we have the hierarchy of geographical concepts, we can assign to each a set of polygon information. Whether that's distributed through Athena or not is a different question. Looks like they are already available, so I would start with those. If Athena were to deliver them we'd have to go through the CDM WG ratification process and create new tables.

@pavgra
Copy link

pavgra commented Mar 5, 2019

@cgreich , how do I get polygon for a concept set from the vocabulary introduced by the PR?

@cgreich
Copy link
Contributor

cgreich commented Mar 5, 2019

Right now informally. The team will publish them as a CSV file somewhere on the OHDSI website or here.

@pavgra
Copy link

pavgra commented Mar 5, 2019

Great. And this will be repeated for each release? (manual publishing of the CSV)

@cgreich
Copy link
Contributor

cgreich commented Mar 5, 2019

Correct, until we add it to the CDM.

Copy link
Contributor

@hardhouse hardhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need readme.md

@Alexdavv
Copy link
Member Author

Alexdavv commented Apr 9, 2019

Right now informally. The team will publish them as a CSV file somewhere on the OHDSI website or here.

@cgreich @pavgra. Done and available here: ftp://ftp.ohdsi.org/geography/geometry.csv
DDL (Postgres):

CREATE TABLE geometry
(	concept_id int,
	geom geometry(MultiPolygon,4326)
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants