-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSM v1 release code #207
OSM v1 release code #207
Conversation
Where can I see the data in dev? |
In dev_osm schema |
What about polygons for the areas? Will there be a coupled CSV / any other data file with |
@pavgra Sure, concept_code + geometry is already in the used source and csv may be exported now. Once vocabulary is released, the concept_id + geometry pairs will be available as well. |
The reason I'm asking:
|
It's non needed there now since CDM is not ready for storing the
Ok, good. We`re ready to discuss with Athena developers. |
From what I recap (OHDSI/CommonDataModel#220 (comment)), it was decided not to store any binary data (polygons) in CDM. Plus, the data is required for separate apps / ETL, not for the CDM itself (the CDM itself will contain precomputed links and relations of entities from medical to geo domains). Therefore, not sure what you are waiting for. |
Not sure what you guys are debating. Now that we have the hierarchy of geographical concepts, we can assign to each a set of polygon information. Whether that's distributed through Athena or not is a different question. Looks like they are already available, so I would start with those. If Athena were to deliver them we'd have to go through the CDM WG ratification process and create new tables. |
@cgreich , how do I get polygon for a concept set from the vocabulary introduced by the PR? |
Right now informally. The team will publish them as a CSV file somewhere on the OHDSI website or here. |
Great. And this will be repeated for each release? (manual publishing of the CSV) |
Correct, until we add it to the CDM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need readme.md
No description provided.