-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location table changes (add region_concept_id) #252
Comments
Nice calculation, but we will not be able to always assign the lowest level geographical information, because we may not have that detail.. E.g., if all we know the Location is Massachusetts, then the town of Rutland in Worcester County is the center point. However, the true Location could be in any other place in Massachusetts. The ETLer has to decide what level in the geo hierarchy to pick based on the information in the source data. |
Obviously, my demo script assumes that you have precise latitude and longitude (the most accurate case). Otherwise, there may be a variety of cases requiring individual approach and custom logic during ETL. |
This will be discussed at the 4/9/2019 CDM Meeting |
@clairblacketer , so what are the next steps to get the appropriate changes into |
@clairblacketer , since this proposal received more than 90% of support, can we proceed with merging it into the development version of CDM? |
@pavgra this was added to the development branch |
please post where can I find in "dev wiki" the location table revised description (per this proposal) (not just the DDL code) |
@vojtechhuser you caught me! I have not yet added a "dev wiki" with descriptions of additions, though it is on my list and I will post a link as soon as it is ready. |
Closing this as these changes were proposed prior to us adding country and latitude and longitude to the location table. This can be reopened if necessary. |
Location table changes (add region_concept_id)
Proposal Owner: Pavel Grafkin, Gowtham Rao
Discussion: #220, OHDSI/WebAPI#649
Proposal overview:
region_concept_id
column tolocation
tableDescription
We would like to use administrative areas as part of cohort entry event, cohort inclusion criteria, enhance cohort characterization using the areas, create heatmaps and do clustering based on the areas.
To achieve this, as a first step, Geo Vocabularies were proposed (OHDSI/WebAPI#649 (comment)) and implemented (OHDSI/Vocabulary-v5.0#207). The geo vocabularies represent ontologies of administrative areas (e.g. Country -> State -> County -> Township).
The second necessary step is linkage of records in
location
table to the administrative areas. Even though the relations of geo concepts and locations represent derived information, not all of OHDSI supported DBs have geo capabilities (and therefore we cannot compute the relations between a location and geo concepts inside DB - OHDSI/WebAPI#649 (comment)) plus the computation of the relations is pretty compute intensive to do it on-demand, therefore there is a need of pre-calculation and physical reference storage. We need to store only a link from a location to its lower-level administrative area (concept_id). Other, higher level administrative areas, can be retrieved viaconcept_ancestor
.Location to administrative area pre-calculation
(using Postgres)
(where
polygon
stores GeoJSON)Proposed implementation
#251
The text was updated successfully, but these errors were encountered: