Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] web_switch_context_warning #1289

Merged
merged 8 commits into from
Jun 14, 2019

Conversation

AdriaGForgeFlow
Copy link
Contributor

Standard migration of module web_switch_company_warning to v12 from #1288

cc ~ @eficent

hparfr and others added 6 commits May 24, 2019 14:21
… to reload the page

[fix] .rst formatting

[FIX] web_switch_company_warning

Remove place holders in readme
Add "use strict" in js

[UPD] prefix versions with 8.0

[MIG] Make modules uninstallable

[MIG] Rename manifest files
Lint

Switch to old name

[UPD] Update web_switch_company_warning.pot

[ADD] icon.png
[UPD] Update web_switch_company_warning.pot
@pedrobaeza pedrobaeza added this to the 12.0 milestone May 24, 2019
@tbaden
Copy link
Member

tbaden commented May 24, 2019

could you please fix these travis warnings:

logs

************* Module web_switch_company_warning
web_switch_company_warning/static/src/js/switch_company_warning.js:7: [W7903(javascript-lint), ] Expected space or tab after '//' in comment. [Error/spaced-comment]
web_switch_company_warning/static/src/js/switch_company_warning.js:8: [W7903(javascript-lint), ] Expected space or tab after '//' in comment. [Error/spaced-comment]
web_switch_company_warning/static/src/js/switch_company_warning.js:11: [W7903(javascript-lint), ] Comments should not begin with a lowercase character. [Error/capitalized-comments]
web_switch_company_warning/static/src/js/switch_company_warning.js:11: [W7903(javascript-lint), ] Expected space or tab after '//' in comment. [Error/spaced-comment]
web_switch_company_warning/static/src/js/switch_company_warning.js:16: [W7903(javascript-lint), ] Missing space before function parentheses. [Error/space-before-function-paren]
web_switch_company_warning/static/src/js/switch_company_warning.js:19: [W7903(javascript-lint), ] Line 19 exceeds the maximum line length of 80. [Error/max-len]
web_switch_company_warning/static/src/js/switch_company_warning.js:24: [W7903(javascript-lint), ] Expected space(s) after "if". [Error/keyword-spacing]
web_switch_company_warning/static/src/js/switch_company_warning.js:33: [W7903(javascript-lint), ] Missing space before function parentheses. [Error/space-before-function-paren]
web_switch_company_warning/static/src/js/switch_company_warning.js:35: [W7903(javascript-lint), ] Missing trailing comma. [Error/comma-dangle]
web_switch_company_warning/static/src/js/switch_company_warning.js:39: [W7903(javascript-lint), ] Missing space before function parentheses. [Error/space-before-function-paren]
web_switch_company_warning/static/src/js/switch_company_warning.js:43: [W7903(javascript-lint), ] Missing trailing comma. [Error/comma-dangle]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:1: [W7903(javascript-lint), ] Use the function form of 'use strict'. [Error/strict]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:2: [W7903(javascript-lint), ] Expected space or tab after '//' in comment. [Error/spaced-comment]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:3: [W7903(javascript-lint), ] Expected space or tab after '//' in comment. [Error/spaced-comment]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:5: [W7903(javascript-lint), ] Implicit global variable, assign as global property instead. [Error/no-implicit-globals]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:6: [W7903(javascript-lint), ] Implicit global variable, assign as global property instead. [Error/no-implicit-globals]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:8: [W7903(javascript-lint), ] Use the function form of 'use strict'. [Error/strict]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:8: [W7903(javascript-lint), ] Missing space before function parentheses. [Error/space-before-function-paren]
web_switch_company_warning/static/src/js/switch_company_warning_worker.js:17: [W7903(javascript-lint), ] Line 17 exceeds the maximum line length of 80. [Error/max-len]

@pedrobaeza
Copy link
Member

Why this one is called web_switch_company_warning and not web_switch_context_warning?

@AdriaGForgeFlow
Copy link
Contributor Author

Why this one is called web_switch_company_warning and not web_switch_context_warning?

I was waiting for some feedback on the renaming of the module. I assume web_switch_context_warning is ok then.

Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -0,0 +1,3 @@
* If the browser don't implement Sharded Worker (http://www.w3.org/TR/workers/#sharedworker), the warning message will not be displayed (there is no polyfill).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sharded -> Shared

@AdriaGForgeFlow AdriaGForgeFlow changed the title [12.0][MIG] web_switch_company_warning [12.0][MIG] web_switch_context_warning Jun 14, 2019
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit d1086e6 into OCA:12.0 Jun 14, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2019
40 tasks
@LoisRForgeFlow LoisRForgeFlow deleted the 12.0-mig-web_switch_company_warning branch June 18, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants