-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] web_switch_context_warning #1289
[12.0][MIG] web_switch_context_warning #1289
Conversation
… to reload the page [fix] .rst formatting [FIX] web_switch_company_warning Remove place holders in readme Add "use strict" in js [UPD] prefix versions with 8.0 [MIG] Make modules uninstallable [MIG] Rename manifest files
Lint Switch to old name [UPD] Update web_switch_company_warning.pot [ADD] icon.png
[UPD] Update web_switch_company_warning.pot
could you please fix these travis warnings: logs
|
Why this one is called |
I was waiting for some feedback on the renaming of the module. I assume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -0,0 +1,3 @@ | |||
* If the browser don't implement Sharded Worker (http://www.w3.org/TR/workers/#sharedworker), the warning message will not be displayed (there is no polyfill). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sharded -> Shared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
Standard migration of module web_switch_company_warning to v12 from #1288
cc ~ @eficent