[11.0][MIG] web_switch_context_warning #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdriaGForgeFlow
force-pushed
the
11.0-mig-web_switch_company_warning
branch
from
c30ca40 to
69a7236
Compare
|
A bit of commit squashing is recommended |
AdriaGForgeFlow
force-pushed
the
11.0-mig-web_switch_company_warning
branch
from
69a7236 to
839e856
Compare
tbaden
suggested changes
May 24, 2019
There was a problem hiding this comment.
thanks for the work 👍
I did a code review: here some changes.
for js it's the easiest way to use eslint with the oca configuration
web_switch_company_warning/static/src/js/switch_company_warning.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning_worker.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning_worker.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning_worker.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning_worker.js
Outdated
Show resolved
Hide resolved
web_switch_company_warning/static/src/js/switch_company_warning_worker.js
Outdated
Show resolved
Hide resolved
… to reload the page [fix] .rst formatting [FIX] web_switch_company_warning Remove place holders in readme Add "use strict" in js [UPD] prefix versions with 8.0 [MIG] Make modules uninstallable [MIG] Rename manifest files
Lint Switch to old name [UPD] Update web_switch_company_warning.pot [ADD] icon.png
[UPD] Update web_switch_company_warning.pot
AdriaGForgeFlow
force-pushed
the
11.0-mig-web_switch_company_warning
branch
from
d52c6fc to
9a90be1
Compare
AdriaGForgeFlow
force-pushed
the
11.0-mig-web_switch_company_warning
branch
from
9a90be1 to
48ccea1
Compare
AdriaGForgeFlow
changed the title
AdriaGForgeFlow
force-pushed
the
11.0-mig-web_switch_company_warning
branch
from
5f00d3a to
99cdb60
Compare
LoisRForgeFlow
approved these changes
Jun 6, 2019
|
@tbaden all your comments were attended, could you please update your review? @pedrobaeza are you ok with the renaming done here? |
|
Not sure if |
tarteo
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration of module web_switch_context_warning to v11 from #1287
cc ~ @eficent