Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_timesheet_task_stage: Disable automatic hotkeys #278

Merged

Conversation

yajo
Copy link
Member

@yajo yajo commented Oct 2, 2019

Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.

See how it looks like without this patch:
Captura de pantalla de 2019-10-02 10-46-09

Here you can see how the patch works.

@Tecnativa TT19205

Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
@alexey-pelykh
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-278-by-alexey-pelykh-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 2, 2019
Signed-off-by alexey-pelykh
@alexey-pelykh
Copy link
Contributor

@yajo runbot is 🔴:

raise ValidationError(_('Invalid view %s definition in %s') % (view.name, view.arch_fs))
odoo.exceptions.ValidationError: ('Invalid view account.analytic.line.tree definition in hr_timesheet_task_stage/views/account_analytic_line.xml', None)

@OCA-git-bot
Copy link
Contributor

@alexey-pelykh your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-278-by-alexey-pelykh-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yajo
Copy link
Member Author

yajo commented Oct 2, 2019

I opened odoo/odoo#37774 to fix that.

@pedrobaeza
Copy link
Member

It's merged now, so retrying

@pedrobaeza pedrobaeza closed this Oct 3, 2019
@pedrobaeza pedrobaeza reopened this Oct 3, 2019
@yajo
Copy link
Member Author

yajo commented Oct 3, 2019

I think you can issue the /merge so it builds a new runbot.

@pedrobaeza
Copy link
Member

You are right

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-278-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 3, 2019
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 62077f1 into OCA:12.0 Oct 3, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a3eb76c. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 12.0-hr_timesheet_task_stage-no_hotkey branch October 3, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants