[IMP] project_timesheet_time_control: ❤️ 4 UX #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
reviewed
Sep 30, 2019
Tardo
suggested changes
Sep 30, 2019
There's no constraint that forbids creating 2 lines with 0 time. Maybe I should add a unique constraint to avoid that? |
|
I don't think we should control that. |
|
That's what I though at first also. After having these controls in place, it's more likely that you create your lines from projects/tasks view than timesheet ones. 🤔 Maybe I could add a button to create a line from scratch from the menu, opening the wizard without smar fills, to let user autostop latest line. |
|
Uhm, maybe we can make a similar screen to the attendance one with big button for starting and stopping. |
|
That'd be much harder than just adding a menu item that opens the wizard. It would involve JS. I think the menu item should be enough |
|
Well, let's put it on the roadmap. I don't see the menu too much added value. |
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
4f6e1aa to
c78e306
Compare
|
I thought about it and it makes sense. I added this menu: Timesheets > Timesheet > Start work It opens this wizard, without autocompletes. In the screenshot you can see the obvious benefit of doing it this way instead of just creating a new record: it warns about an old running timer and lets you go to it or stop it and start a new timer with one click:
So, although I think we will use it less because the new buttons in tasks and projects are so cool, I still think it's good to have it for those that want to input a new line from scratch. After all, it's just an action and menu item, so easy it's done already. |
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
c78e306 to
cd56285
Compare
|
Please add Spanish translation |
|
Done. I just have to add some tests and try to ensure the wizard always features a hotkey to make it more handy. |
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
cd56285 to
659e5a2
Compare
yajo
added a commit
to Tecnativa/timesheet
that referenced
this pull request
Oct 2, 2019
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
659e5a2 to
65d34a9
Compare
Enforcing a hotkey is very error-prone in a wizard, it's easier to rely on the automatic one, as far as there are available, so I opened OCA/timesheet#278 and patched a little bit kanban and tree views here to add more chances for the wizard button to get a hotkey. Now it will have one almost always. |
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
65d34a9 to
8a8247a
Compare
|
Can you improve a bit more test coverage? |
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
8a8247a to
e551601
Compare
|
Yes, it's on my roadmap, do not merge still please. |
yajo
changed the title
yajo
force-pushed
the
12.0-project_timesheet_time_control-ux_love
branch
from
e551601 to
8af00ff
Compare
|
If I'm not wrong, this should go 100% ☔ now. |
|
This PR has the |
|
Congratulations, your PR was merged at c4137d5. Thanks a lot for contributing to OCA. ❤️ |
OCA-git-bot
changed the title
yajo
added a commit
to Tecnativa/timesheet
that referenced
this pull request
Oct 11, 2019
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
manuelcalerosolis
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Feb 11, 2020
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
manuelcalerosolis
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Feb 27, 2020
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
pedrobaeza
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Jul 3, 2020
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
pedrobaeza
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Sep 26, 2020
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
paidykumar-dreambits
pushed a commit
to paidykumar-dreambits/timesheet
that referenced
this pull request
Feb 6, 2021
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
fshah-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
Mar 15, 2021
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
fshah-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
Mar 31, 2021
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
dsolanki-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
May 3, 2021
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
hkapatel-initos
pushed a commit
to initOS/timesheet
that referenced
this pull request
Sep 3, 2021
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
manuelcalerosolis
pushed a commit
to xtendoo-corporation/timesheet
that referenced
this pull request
Jun 28, 2022
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
LudLaf
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Nov 21, 2022
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
pedrobaeza
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Nov 27, 2022
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
aktiv-heli-kantawala
pushed a commit
to aktiv-heli-kantawala/timesheet
that referenced
this pull request
Jun 6, 2023
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
carolinafernandez-tecnativa
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Sep 25, 2023
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
carolinafernandez-tecnativa
pushed a commit
to Tecnativa/timesheet
that referenced
this pull request
Sep 25, 2023
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
mde-scopea
pushed a commit
to mde-scopea/timesheet
that referenced
this pull request
Jan 31, 2024
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
bizzappdev
pushed a commit
to BizzAppDev-Systems/timesheet
that referenced
this pull request
Mar 15, 2024
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
bizzappdev
pushed a commit
to BizzAppDev-Systems/timesheet
that referenced
this pull request
Mar 15, 2024
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
RogerSans
pushed a commit
to sygel-technology/timesheet
that referenced
this pull request
Jul 29, 2024
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
RogerSans
pushed a commit
to sygel-technology/timesheet
that referenced
this pull request
Jul 29, 2024
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
HeliconiaSolutions
pushed a commit
to HeliconiaIO/timesheet
that referenced
this pull request
Jan 2, 2025
Without this attribute, Odoo will try to assign a hotkey to buttons. It's very unlikely that these buttons have to be used like this, and since there's a limited number of available hotkeys, they steal them to more important ones like the wizard proposed at OCA/project#586.
jdebetaz
pushed a commit
to jdebetaz/oca-timesheet
that referenced
this pull request
Jan 15, 2025
Following the changes from OCA/project#586, here I implement the same UX when using it with CRM leads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge improvement in this module's usability, although basic functionality stays the same. Let me summmarize:
account.analytic.lineviews, the Stop button is replaced by colorful Resume/Stop buttons.account.analytic.linerecord and auto-stop the previous running timer, if any.project.projectandproject.taskviews, I added the same buttons (well... it's Start instead of Resume, because you could not have worked before in that project or task, but it behaves the same).project.task, Start will duplicate meaningful fields from your latest line in that task.project.project, Start will duplicate meaningful fields your latest line in that project that had no task associated.@Tecnativa TT19205
Inspired by OCA/timesheet#139.