Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] base_technical_user #1837

Merged
merged 18 commits into from
Jun 8, 2020
Merged

[13.0][MIG] base_technical_user #1837

merged 18 commits into from
Jun 8, 2020

Conversation

HviorForgeFlow
Copy link
Member

@HviorForgeFlow HviorForgeFlow commented May 26, 2020 •
edited
Loading

Cédric Pigeon and others added 17 commits May 26, 2020 16:22
@HviorForgeFlow
[10.0] add new module to manage technical user on company
aafc05d 
[CHG] add name to wml tag to make override easier

[FIX] remove domain on active field
@oca-transbot @HviorForgeFlow
OCA Transbot updated translations from Transifex
4e2359f 
OCA Transbot updated translations from Transifex
@hugosantosred @HviorForgeFlow
[MIG] base_technical_user to V11
347c1a1
@oca-travis @HviorForgeFlow
[UPD] Update base_technical_user.pot
72acefc
@osoul @HviorForgeFlow
Added translation using Weblate (Arabic)
285ddc2
@simahawk @HviorForgeFlow
Global pylint cleanup
862f847
@OCA-git-bot @HviorForgeFlow
[ADD] icon.png
1553dc1
@florian-dacosta @HviorForgeFlow
Migrate base_technical_user to version 12
c02b72b
@oca-travis @HviorForgeFlow
[UPD] Update base_technical_user.pot
64173a9
@OCA-git-bot @HviorForgeFlow
[UPD] README.rst
8a49455
@oca-transbot @HviorForgeFlow
Update translation files
50c7adf 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/
@OCA-git-bot @HviorForgeFlow
[UPD] README.rst
c9dd091
@pedrocs-exo @HviorForgeFlow
Translated using Weblate (Portuguese)
37bd542 
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/pt/
@liweijie0812 @HviorForgeFlow
Added translation using Weblate (Chinese (Simplified))
fc5440a
@liweijie0812 @HviorForgeFlow
Translated using Weblate (Chinese (Simplified))
cdda774 
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-12.0/server-tools-12.0-base_technical_user
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_technical_user/zh_CN/
@HviorForgeFlow
[IMP] base_technical_user: black, isort, prettier
5204860
@HviorForgeFlow
[MIG] base_technical_user: Migration to 13.0
0e5ea53
LoisRForgeFlow
LoisRForgeFlow approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pedrobaeza
Copy link
Member

pedrobaeza commented May 26, 2020 •
edited
Loading

I think this module is not needed anymore, as this is the exact definition of OdooBot/__system__ user.

@pedrobaeza pedrobaeza added this to the 13.0 milestone May 26, 2020
@florian-dacosta
Copy link
Contributor

I am not sure about multi company case? It may be usefull to have a different technical user with a dedicated company in some cases no?

@pedrobaeza
Copy link
Member

No, that user is tolerant with any company.

@HviorForgeFlow HviorForgeFlow force-pushed the 13.0-mig-base_technical_user branch from 7dd273c to af2e15a Compare May 27, 2020 07:15
@HviorForgeFlow HviorForgeFlow force-pushed the 13.0-mig-base_technical_user branch from f62cf4c to 3832b35 Compare May 27, 2020 07:38
@rousseldenis
Copy link
Contributor

rousseldenis commented May 27, 2020 •
edited
Loading

No, that user is tolerant with any company.

Indeed, but @florian-dacosta is right, I think you need to change OdooBot company if you want to do actions in that context.

The aim here is to have a fixed user per company.

Something like 'MyCompanyA_Bot', 'MyCompanyB_Bot

OdooBot is the big boss Bot user

ValentinVinagre
ValentinVinagre approved these changes Jun 1, 2020
View reviewed changes
Copy link

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

@OCA/core-maintainers

@simahawk
Copy link
Contributor

simahawk commented Jun 5, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-1837-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 5, 2020
@OCA-git-bot
Merge PR #1837 into 13.0
2fcd769 
Signed-off-by simahawk
@rousseldenis
Copy link
Contributor

@simahawk

@simahawk
Copy link
Contributor

simahawk commented Jun 8, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-1837-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bfee6ab into OCA:13.0 Jun 8, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 656dad1. Thanks a lot for contributing to OCA. ❤️

@HviorForgeFlow HviorForgeFlow deleted the 13.0-mig-base_technical_user branch June 8, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@AdriaGForgeFlow AdriaGForgeFlow AdriaGForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.