[IMP] add helper for getting a self env with the tech user #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienbeau
force-pushed
the
10.0-base_technical_user_helper
branch
from
6a12997 to
e13fd3b
Compare
acsonefho
reviewed
Apr 24, 2020
base_technical_user/models/models.py
Outdated
| return self_sudoer | ||
|
|
||
|
|
||
| models.BaseModel.sudo_tech = sudo_tech |
There was a problem hiding this comment.
Why not doing like this:
class Base(models.AbstractModel):
_inherit = 'base'
def sudo_tech(self, raise_if_missing=False):
self_sudoer = self
tech_user = self.env.user.company_id.user_tech_id
if tech_user:
self_sudoer = self.sudo(tech_user.id)
elif raise_if_missing:
raise UserError("The technical user is missing in the company {}".format(self.env.user.company_id.name))
return self_sudoer
It's more "Odoo"?
There was a problem hiding this comment.
Sorry I mix the version. I was think that this was not possible on 10 and only work since 11. But it's work since 9. I fix it
sebastienbeau
force-pushed
the
10.0-base_technical_user_helper
branch
from
e13fd3b to
bbf07b7
Compare
simahawk
requested changes
Apr 24, 2020
sebastienbeau
force-pushed
the
10.0-base_technical_user_helper
branch
from
bbf07b7 to
7540fe7
Compare
|
@simahawk fixed ! |
simahawk
approved these changes
Apr 24, 2020
sebastienbeau
force-pushed
the
10.0-base_technical_user_helper
branch
from
7540fe7 to
266d809
Compare
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 9636d1a. Thanks a lot for contributing to OCA. ❤️ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.