[10.0] MIG sale documents comments, renaming in sale_comment_propagation #509

hurrinico · 2017-07-18T10:19:59Z

Porting of @eLBati version
#468

eLBati · 2017-07-18T12:22:45Z

sale_documents_comments/__manifest.py

@@ -7,7 +7,7 @@



@hurrinico __manifest.py -> __manifest__.py

hurrinico · 2017-07-18T13:23:13Z

@eLBati fixed error manifest and flake8

eLBati · 2017-07-18T20:45:53Z

@hurrinico

sale_documents_comments/models/account.py:19:9: F841 local variable 'val' is assigned to but never used
sale_documents_comments/models/sale.py:32:1: W293 blank line contains whitespace
sale_documents_comments/models/sale.py:36:9: F841 local variable 'val' is assigned to but never used

hurrinico · 2017-07-19T10:39:55Z

@eLBati travis is green

pedrobaeza · 2017-07-19T11:16:42Z

Check my comment about module name in #468 (comment)

hurrinico · 2017-07-19T12:37:01Z

@pedrobaeza done

tafaRU · 2017-07-20T08:34:14Z

sale_comment_propagation/README.rst

+
+In sale order
+
+.. image:: /sale_documents_comments/images/sale_comments.png


fix path after renaming

pedrobaeza · 2017-07-24T16:54:44Z

@chienandalu please review thie PR and propose the module renaming in OpenUpgrade v9 to assure path from odoomrp-wip v8 module to OCA one on v9/v10

chienandalu

Thanks for your work, @hurrinico! Some comments below:

Maybe you could try to squash some commits together (mainly the translation ones)
Tests would be very welcome.

chienandalu · 2017-07-26T10:46:39Z

sale_documents_comments/models/account.py

 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html

-from openerp import models, fields, api
+from odoo import models, fields, api


Sort alphabetically

chienandalu · 2017-07-26T10:48:44Z

sale_documents_comments/README.rst

@@ -49,6 +49,8 @@ Contributors
 * Pedro M. Baeza <[email protected]>


Please, change it to [email protected]

chienandalu · 2017-07-26T10:50:58Z

sale_documents_comments/__init__.py

-# © 2015 Esther Martín <[email protected]> - Avanzosc S.L.
+# Copyright 2015 Ainara Galdona - AvanzOSC
+# Copyright 2015 Oihane Crucelaegui - AvanzOSC
+# Copyright 2015 Esther Martín <[email protected]> - Avanzosc S.L.


There's no real need of authoring in __init__.py files. Better to keep them as minimalistic as possible.

chienandalu · 2017-07-26T10:52:05Z

sale_documents_comments/__manifest__.py

@@ -18,7 +18,8 @@
    "author": "OdooMRP team, "
              "AvanzOSC, "
              "Serv. Tecnol. Avanzados - Pedro M. Baeza, "


Please, change it to Pedro's new company Tecnativa

chienandalu · 2017-07-26T10:52:44Z

sale_documents_comments/__manifest__.py

@@ -18,7 +18,8 @@
    "author": "OdooMRP team, "
              "AvanzOSC, "
              "Serv. Tecnol. Avanzados - Pedro M. Baeza, "
-              "Odoo Community Association (OCA)",
+              "Odoo Community Association (OCA), "
+              "Agile Businnes Group",
    "category": "Sales",
    "website": "http://www.odoomrp.com",


Change it to https://odoo-community.org/

chienandalu · 2017-07-26T11:00:12Z

sale_documents_comments/models/partner.py

 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html

-from openerp import models, fields
+from odoo import models, fields


Sort alphabetically

chienandalu · 2017-07-26T11:00:28Z

sale_documents_comments/models/sale.py

 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html

-from openerp import models, fields, api
+from odoo import models, fields, api


Sort alphabetically

chienandalu · 2017-07-26T11:02:00Z

sale_documents_comments/models/stock.py

 # License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html

-from openerp import api, models, fields
+from odoo import api, models, fields


Sort alphabetically

chienandalu · 2017-07-26T11:05:18Z

sale_comment_propagation/__manifest__.py

+
+{
+    "name": "Comments for sale documents (order, picking and invoice)",
+    "version": "10.0.0.1.0",


Follow guidelines for version numbering: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers. This migration should start on 10.0.1.0.0 and then bump according to said guidelines.

chienandalu · 2017-07-26T11:16:19Z

sale_comment_propagation/models/stock.py

+        string='Propagated internal comments')
+
+    @api.one
+    @api.onchange('partner_id')


Don't use @api.one with @api.onchange or it will crash.
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-10.0

(besides @api.one is deprecated)

rafaelbn

Tested in runbot this module has an incompatibility with sale_order_margin_percent

  File "/home/odoo/build/OCA/sale-workflow/sale_order_margin_percent/models/sale_order_margin.py", line 15, in _compute_percent
    if self.margin and self.amount_untaxed:
  File "/.repo_requirements/odoo/odoo/fields.py", line 864, in __get__
    record.ensure_one()
  File "/.repo_requirements/odoo/odoo/models.py", line 4826, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: sale.order(18, 19)

rafaelbn · 2017-07-31T08:57:28Z

sale_comment_propagation/README.rst

+With this module you can add specific comments to a customer, for sale order,
+delivery order and invoices. Part of the info will be passed from one to other.
+Those data will be automatically added to each item.
+


Please add a comment that this module don't add this comments to any report. A user could expect that.

rafaelbn · 2017-07-31T09:00:16Z

Hi @hurrinico could you please to attend comments ? Let us know, thanks!

hurrinico · 2017-07-31T09:04:45Z

Hi @pedrobaeza i'll work on it as soon as possible.

[MOD] Vistos cambios necesarios despues del PR [MOD] [MOD] Update stock.py Según código corregido issue 80, pero hay que probar

[IMP] PEP8

[FIX] Pylint fixing <sale_documents_comments> [FIX] Pylint fixing <warning_log> [MOD] Translated module <sale_documents_comments>

[IMP] sale_documents_comments: añadir comentario del parent cuando exista + pasar codigo a la nueva api [FIX] sale_documents_comments: visual indentation corregido [IMP] sale_documents_comments : inicializar las variables en caso de no tener comentario

…lse al concatenar strings

[FIX] <sale_documents_comments> space adding at start avoided [IMP] <sale_documents_comments> required changes in string replacing [FIX] <sale_documents_comments> Comments not taken from partner fixed

[IMP] <sale_documents_comments> Just in case, take order partner_invoice_id if partner_id is not present

…nt 'type' IMP using OCA templates IMP description and images IMP copyright headers following OCA template

and renaming in sale_documents_comments sale_comment_propagation

hurrinico · 2017-10-26T08:05:38Z

Fixed commit list and set runbot and travis green

pedrobaeza · 2017-10-26T08:10:07Z

@tafaRU can you update your review?

SimoRubi

Code review, and check ❌ Travis

SimoRubi · 2018-11-09T09:59:37Z

sale_comment_propagation/models/sale.py

+        res['sale_comment'] = '\n'.join(comment_list)
+        return res
+
+    @api.multi


Suggested change

@api.multi

sale_comment_propagation/models/stock.py

SimoRubi · 2018-11-09T10:12:42Z

sale_comment_propagation/models/stock.py

+            if partner._get_invoice_comments():
+                pcomment_list.append(partner._get_invoice_comments())
+        values['sale_comment'] = '\n'.join(pcomment_list)
+        return super(StockPicking, self)._create_invoice_from_picking(


I can't find this method in v10 (in v8 was stock_account.stock.stock_picking._create_invoice_from_picking)

Co-Authored-By: hurrinico <[email protected]>

rousseldenis · 2020-12-07T22:27:07Z

@hurrinico @SimoRubi Is this still applicable ?

rousseldenis · 2021-08-04T12:41:24Z

Closing as very old. Feel free to reopen it if needed.

hurrinico mentioned this pull request Jul 18, 2017

[ADD] Add new module sale_documents_comments #492

Closed

eLBati suggested changes Jul 18, 2017

View reviewed changes

sale_documents_comments/__manifest.py Outdated

@@ -7,7 +7,7 @@

Copy link

Member

eLBati Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hurrinico __manifest.py -> __manifest__.py

hurrinico changed the title ~~[10.0] MIG sale documents comments~~ [10.0] MIG sale documents comments, renaming in sale_comment_propagation Jul 19, 2017

eLBati approved these changes Jul 19, 2017

View reviewed changes

tafaRU requested changes Jul 20, 2017

View reviewed changes

chienandalu suggested changes Jul 26, 2017

View reviewed changes

chienandalu mentioned this pull request Jul 26, 2017

[ADD] sale_documents_comments renamed OCA/OpenUpgrade#976

Merged

rafaelbn added this to the 10.0 milestone Jul 28, 2017

rafaelbn added the needs review label Jul 28, 2017

rafaelbn reviewed Jul 31, 2017

View reviewed changes

oihane and others added 12 commits October 26, 2017 09:36

[ADD] New module <sale_documents_comments>

769691d

[MOD] Vistos cambios necesarios despues del PR [MOD] [MOD] Update stock.py Según código corregido issue 80, pero hay que probar

[IMP] Some flake8

66f05d8

[IMP] PEP8

[MOD] Added translations

a338309

[FIX] Pylint fixing <sale_documents_comments> [FIX] Pylint fixing <warning_log> [MOD] Translated module <sale_documents_comments>

[IMP] Expand AUTHORS

385fa6e

[IMP] sale_documents_comments: añadir comentario del parent cuando exista + pasar codigo a la nueva api [FIX] sale_documents_comments: visual indentation corregido [IMP] sale_documents_comments : inicializar las variables en caso de no tener comentario

[FIX] PEP8

64205e3

[FIX] sale_documents_comments: asegurar de que no se va a pasar un Fa…

5abf761

…lse al concatenar strings

[IMP] <sale_documents_comments> Code cleaning and minor changes

b5c2f89

[FIX] <sale_documents_comments> space adding at start avoided [IMP] <sale_documents_comments> required changes in string replacing [FIX] <sale_documents_comments> Comments not taken from partner fixed

[FIX] sale_documents_comments: flake8

ad4d101

[IMP] <sale_documents_comments> Code cleaning, fixes #848

40671d5

[IMP] <sale_documents_comments> Just in case, take order partner_invoice_id if partner_id is not present

Slovene translations of odoomrp modules

ff05aac

OCA Transbot updated translations from Transifex

940c199

[FIX] sale_documents_comments: fixes #1027

c6c712e

pedrobaeza and others added 4 commits October 26, 2017 09:36

OCA Transbot updated translations from Transifex

fd8439e

[MOD] sale_documents_comments: Updated module, remove .pot

7ff160c

FIX TypeError: onchange_partner_id() got an unexpected keyword argume…

763eda7

…nt 'type' IMP using OCA templates IMP description and images IMP copyright headers following OCA template

[MIG] sale_documents_comments: Migration to 10.0

56411f8

and renaming in sale_documents_comments sale_comment_propagation

SimoRubi suggested changes Nov 9, 2018

View reviewed changes

[FIX] Remove useless operator

f13a166

Co-Authored-By: hurrinico <[email protected]>

lmignon mentioned this pull request May 14, 2019

[10.0][ADD] Add module sale_stock_delivery_note OCA/stock-logistics-workflow#524

Closed

rousseldenis closed this Aug 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0] MIG sale documents comments, renaming in sale_comment_propagation #509

[10.0] MIG sale documents comments, renaming in sale_comment_propagation #509

hurrinico commented Jul 18, 2017 •

edited

Loading

eLBati Jul 18, 2017

hurrinico commented Jul 18, 2017

eLBati commented Jul 18, 2017

hurrinico commented Jul 19, 2017

pedrobaeza commented Jul 19, 2017

hurrinico commented Jul 19, 2017

tafaRU Jul 20, 2017

pedrobaeza commented Jul 24, 2017

chienandalu left a comment

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

chienandalu Jul 26, 2017

rafaelbn left a comment

rafaelbn Jul 31, 2017

rafaelbn commented Jul 31, 2017

hurrinico commented Jul 31, 2017

hurrinico commented Oct 26, 2017

pedrobaeza commented Oct 26, 2017

SimoRubi left a comment

SimoRubi Nov 9, 2018

SimoRubi Nov 9, 2018

rousseldenis commented Dec 7, 2020

rousseldenis commented Aug 4, 2021


		In sale order

		.. image:: /sale_documents_comments/images/sale_comments.png

		@@ -49,6 +49,8 @@ Contributors
		* Pedro M. Baeza <[email protected]>

[10.0] MIG sale documents comments, renaming in sale_comment_propagation #509

[10.0] MIG sale documents comments, renaming in sale_comment_propagation #509

Conversation

hurrinico commented Jul 18, 2017 • edited Loading

Choose a reason for hiding this comment

hurrinico commented Jul 18, 2017

eLBati commented Jul 18, 2017

hurrinico commented Jul 19, 2017

pedrobaeza commented Jul 19, 2017

hurrinico commented Jul 19, 2017

Choose a reason for hiding this comment

pedrobaeza commented Jul 24, 2017

chienandalu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn commented Jul 31, 2017

hurrinico commented Jul 31, 2017

hurrinico commented Oct 26, 2017

pedrobaeza commented Oct 26, 2017

SimoRubi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rousseldenis commented Dec 7, 2020

rousseldenis commented Aug 4, 2021

hurrinico commented Jul 18, 2017 •

edited

Loading