[ADD] sale_documents_comments renamed #976
Conversation
| @@ -29,6 +29,7 @@ | |||
| 'marketing_security_group': 'mass_mailing_security_group', | |||
| # odoomrp/odoomrp-wip | |||
| 'product_variants_no_automatic_creation': 'product_variant_configurator', | |||
| 'sale_documents_comments': 'sale_comment_propagation', | |||
There was a problem hiding this comment.
the module OCA/sale-workflow#509 is still named sale_comment_propagation, see last commit
There was a problem hiding this comment.
We know that. This is for ensuring the migration path from odoomrp-wip module to OCA. If you have already 8.0 OCA module, this is harmless (well, not yet).
There was a problem hiding this comment.
It has been already done in other odoomrp-wip modules. See
There was a problem hiding this comment.
@chienandalu, you have to include the renaming in the base module where update_module_names is called with merge_modules=True option, as you can have both modules (old and new) in your module list.
chienandalu
force-pushed
the
9.0-PR-sale_documents_comments_renamed
branch
from
6909ef1 to
17530a8
Compare
|
Done @pedrobaeza |
|
But you haven't removed it from apriori.py... |
chienandalu
force-pushed
the
9.0-PR-sale_documents_comments_renamed
branch
from
17530a8 to
1fe8646
Compare
|
Sure, @pedrobaeza... 😅 It's done |
|
@chienandalu, why you put the depends in the head comment? It doesn't depend at all. |
|
@mreficent Yes, now it doesn't. Changed. |
|
It seems Travis has fixed its problem referencing $TRAVIS_COMMIT with forced pushed PRs... |
Related OCA/sale-workflow#509 (comment)
cc @Tecnativa