Correct or disable pylint warnings #72
Conversation
guewen
force-pushed
the
11.0-pylint-warnings
branch
from
7bb141a to
e69bfcc
Compare
| # copyright 2016 Camptocamp | ||
| # license agpl-3.0 or later (http://www.gnu.org/licenses/agpl.html) | ||
|
|
||
| from datetime import datetime, date | ||
| import json | ||
|
|
||
| from odoo.tests import common | ||
|
|
||
| # pylint: disable=odoo-addons-relative-import | ||
| # we are testing, we want to test as we were an external consumer of the API | ||
| from odoo.addons.queue_job.fields import JobEncoder, JobDecoder |
There was a problem hiding this comment.
That's maybe not the place to discuss that, but am I the only with the opinion that tests should run as if they were from the outside, so should use absolute imports rather than relative?
There was a problem hiding this comment.
@guewen you should put instead this import:
from ..fields import JobEncoder, JobDecoderThat's why pylint complains
There was a problem hiding this comment.
Is there any actual case where the relative import would fail?
There was a problem hiding this comment.
I find the point of view of @guewen really relevant.
There was a problem hiding this comment.
Yeah, but with no case, I prefer to be homogeneous across all code, being test or not.
There was a problem hiding this comment.
you should put instead this import:
from ..fields import JobEncoder, JobDecoder
That's why pylint complains
I know, my point is that in tests, I don't want to do that (I do in in addons code for sure).
@pedrobaeza It's not the question of failure, both should work in any case.
It's more a question of what a test is and what the boundaries of the addons are.
If we say that an addon is a library, the tests are definitely not part of this library, they just happen to be in the same folder but they don't belong to the Python package.
There was a problem hiding this comment.
Well, I don't find all that conceptual separation needed. As said, I prefer homogeneity, but as always, maintainers decide and this can be raised for a general discussion for removing that check on tests.
guewen
force-pushed
the
11.0-pylint-warnings
branch
from
e69bfcc to
57bb9ab
Compare
|
Rebased from 11.0 |
The remaining warning is fixed in #71 and a warning is fixed in the checker at OCA/pylint-odoo#201