Correct or disable pylint warnings

OCA · May 25, 2018 · 7bb141a · 7bb141a
1 parent abc3d2f
commit 7bb141a
Show file tree

Hide file tree

Showing 27 changed files with 23 additions and 66 deletions.
diff --git a/queue_job/__init__.py b/queue_job/__init__.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from . import controllers
 from . import fields
 from . import models

diff --git a/queue_job/__manifest__.py b/queue_job/__manifest__.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
 

diff --git a/queue_job/controllers/main.py b/queue_job/controllers/main.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright (c) 2015-2016 ACSONE SA/NV (<http://acsone.eu>)
 # Copyright 2013-2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)

diff --git a/queue_job/exception.py b/queue_job/exception.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2012-2016 Camptocamp
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/queue_job/fields.py b/queue_job/fields.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # copyright 2016 Camptocamp
 # license agpl-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/queue_job/job.py b/queue_job/job.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2013-2016 Camptocamp
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/queue_job/jobrunner/__init__.py b/queue_job/jobrunner/__init__.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright (c) 2015-2016 ACSONE SA/NV (<http://acsone.eu>)
 # Copyright 2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)

diff --git a/queue_job/jobrunner/channels.py b/queue_job/jobrunner/channels.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright (c) 2015-2016 ACSONE SA/NV (<http://acsone.eu>)
 # Copyright 2015-2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
@@ -114,6 +113,7 @@ class SafeSet(set):
     >>> s.remove(1)
     """
     def remove(self, o):
+        # pylint: disable=missing-return,except-pass
         try:
             super(SafeSet, self).remove(o)
         except KeyError:

diff --git a/queue_job/jobrunner/runner.py b/queue_job/jobrunner/runner.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright (c) 2015-2016 ACSONE SA/NV (<http://acsone.eu>)
 # Copyright 2015-2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
@@ -231,6 +230,10 @@ def __init__(self, db_name):
             self._initialize()
 
     def close(self):
+        # pylint: disable=except-pass
+        # if close fail for any reason, it's either because it's already closed
+        # and we don't care, or for any reason but anyway it will be closed on
+        # del
         try:
             self.conn.close()
         except:
@@ -277,6 +280,10 @@ def _initialize(self):
             cr.execute("LISTEN queue_job")
 
     def select_jobs(self, where, args):
+        # pylint: disable=sql-injection
+        # the checker thinks we are injecting values but we are not, we are
+        # adding the where conditions, values are added later properly with
+        # parameters
         query = ("SELECT channel, uuid, id as seq, date_created, "
                  "priority, EXTRACT(EPOCH FROM eta), state "
                  "FROM queue_job WHERE %s" %

diff --git a/queue_job/migrations/10.0.1.0.0/pre-migration.py b/queue_job/migrations/10.0.1.0.0/pre-migration.py
diff --git a/queue_job/models/__init__.py b/queue_job/models/__init__.py
@@ -1,4 +1,2 @@
-# -*- coding: utf-8 -*-
-
 from . import base
 from . import queue_job
diff --git a/queue_job/models/base.py b/queue_job/models/base.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2016 Camptocamp
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/queue_job/models/queue_job.py b/queue_job/models/queue_job.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2013-2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
@@ -53,18 +52,17 @@ class QueueJob(models.Model):
                               readonly=True, store=True)
 
     state = fields.Selection(STATES,
-                             string='State',
                              readonly=True,
                              required=True,
                              index=True)
     priority = fields.Integer()
     exc_info = fields.Text(string='Exception Info', readonly=True)
-    result = fields.Text(string='Result', readonly=True)
+    result = fields.Text(readonly=True)
 
     date_created = fields.Datetime(string='Created Date', readonly=True)
     date_started = fields.Datetime(string='Start Date', readonly=True)
     date_enqueued = fields.Datetime(string='Enqueue Time', readonly=True)
-    date_done = fields.Datetime(string='Date Done', readonly=True)
+    date_done = fields.Datetime(readonly=True)
 
     eta = fields.Datetime(string='Execute only after')
     retry = fields.Integer(string='Current try')
@@ -252,7 +250,6 @@ class JobChannel(models.Model):
 
     name = fields.Char()
     complete_name = fields.Char(compute='_compute_complete_name',
-                                string='Complete Name',
                                 store=True,
                                 readonly=True)
     parent_id = fields.Many2one(comodel_name='queue.job.channel',

diff --git a/queue_job/tests/__init__.py b/queue_job/tests/__init__.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 from . import test_runner_channels
 from . import test_runner_runner
 from . import test_json_field
diff --git a/queue_job/tests/common.py b/queue_job/tests/common.py
@@ -1 +0,0 @@
-# -*- coding: utf-8 -*-

diff --git a/queue_job/tests/test_json_field.py b/queue_job/tests/test_json_field.py
@@ -1,11 +1,13 @@
-# -*- coding: utf-8 -*-
 # copyright 2016 Camptocamp
 # license agpl-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
 from datetime import datetime, date
 import json
 
 from odoo.tests import common
+
+# pylint: disable=odoo-addons-relative-import
+# we are testing, we want to test as we were an external consumer of the API
 from odoo.addons.queue_job.fields import JobEncoder, JobDecoder
 
 

diff --git a/queue_job/tests/test_runner_channels.py b/queue_job/tests/test_runner_channels.py
@@ -1,8 +1,9 @@
-# -*- coding: utf-8 -*-
 # Copyright 2015-2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
 import doctest
+# pylint: disable=odoo-addons-relative-import
+# we are testing, we want to test as we were an external consumer of the API
 from odoo.addons.queue_job.jobrunner import channels
 
 

diff --git a/queue_job/tests/test_runner_runner.py b/queue_job/tests/test_runner_runner.py
@@ -1,8 +1,9 @@
-# -*- coding: utf-8 -*-
 # Copyright 2015-2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 
 import doctest
+# pylint: disable=odoo-addons-relative-import
+# we are testing, we want to test as we were an external consumer of the API
 from odoo.addons.queue_job.jobrunner import runner
 
 

diff --git a/queue_job/views/queue_job_views.xml b/queue_job/views/queue_job_views.xml
@@ -81,9 +81,9 @@
         <field name="name">queue.job.tree</field>
         <field name="model">queue.job</field>
         <field name="arch" type="xml">
-            <tree string="Jobs" create="false"
-                    delete="false"
-                    colors="red:state == 'failed';gray:state == 'done'">
+            <tree create="false" delete="false"
+                  decoration-danger="state == 'failed'"
+                  decoration-muted="state == 'done'">
                 <field name="name"/>
                 <field name="model_name"/>
                 <field name="state"/>
@@ -189,7 +189,7 @@
         <field name="name">queue.job.channel.tree</field>
         <field name="model">queue.job.channel</field>
         <field name="arch" type="xml">
-            <tree string="Channels">
+            <tree>
                 <field name="complete_name"/>
             </tree>
         </field>
@@ -233,7 +233,7 @@
         <field name="name">queue.job.function.tree</field>
         <field name="model">queue.job.function</field>
         <field name="arch" type="xml">
-            <tree string="Job Functions" create="false" delete="false">
+            <tree create="false" delete="false">
                 <field name="name"/>
                 <field name="channel_id"/>
             </tree>

diff --git a/test_queue_job/__init__.py b/test_queue_job/__init__.py
@@ -1,2 +1 @@
-# -*- coding: utf-8 -*-
 from . import models
diff --git a/test_queue_job/__manifest__.py b/test_queue_job/__manifest__.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/test_queue_job/models/__init__.py b/test_queue_job/models/__init__.py
@@ -1,3 +1 @@
-# -*- coding: utf-8 -*-
-
 from . import test_models
diff --git a/test_queue_job/models/test_models.py b/test_queue_job/models/test_models.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/test_queue_job/tests/__init__.py b/test_queue_job/tests/__init__.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from . import test_job
 from . import test_job_channels
 from . import test_related_actions
diff --git a/test_queue_job/tests/test_job.py b/test_queue_job/tests/test_job.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/test_queue_job/tests/test_job_channels.py b/test_queue_job/tests/test_job_channels.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
 

diff --git a/test_queue_job/tests/test_related_actions.py b/test_queue_job/tests/test_related_actions.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Copyright 2014-2016 Camptocamp SA
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,3 @@
		# -- coding: utf-8 --
		# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html)


Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1 @@
		# -- coding: utf-8 --

		from . import test_models