Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appended allowRemoteCacheManagement key into web.config to allow remote cache management (clear cache). #59

Merged
merged 18 commits into from
Sep 4, 2018
Merged

Appended allowRemoteCacheManagement key into web.config to allow remote cache management (clear cache). #59

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
07896e1
Merge branch 'dev'
joelverhagen Nov 30, 2017
2972fb3
Merge branch 'dev'
joelverhagen Nov 30, 2017
c7d9144
Merge branch 'dev'
joelverhagen Dec 15, 2017
f507bd2
Merge branch 'dev' into master
joelverhagen Feb 5, 2018
bf717c1
Merge branch 'dev' into master
joelverhagen Feb 12, 2018
2ee751a
Merge pull request #57 from NuGet/dev
chenriksson Feb 26, 2018
daf5b2d
Appended allowRemoteCacheManagement key into web.config to allow remo…
ezverev Mar 29, 2018
352c1ca
Revert "Appended allowRemoteCacheManagement key into web.config to al…
ezverev Mar 29, 2018
795a168
Appended allowRemoteCacheManagement key into web.config to allow remo…
ezverev Mar 29, 2018
b436e52
Merge branch 'dev' into master
ezverev Mar 29, 2018
07025c4
Store web server settings in user file.
ezverev Mar 29, 2018
66b40ee
Appended allowRemoteCacheManagement key into web.config to allow remo…
ezverev Mar 29, 2018
257b7a2
Revert "Appended allowRemoteCacheManagement key into web.config to al…
ezverev Mar 29, 2018
8aeb3d0
Appended allowRemoteCacheManagement key into web.config to allow remo…
ezverev Mar 29, 2018
0011c0c
Store web server settings in user file.
ezverev Mar 29, 2018
6882375
Merge branch 'master' of https://github.com/ezverev/NuGet.Server
ezverev Mar 29, 2018
2a052b3
Update Web.config
ezverev Aug 28, 2018
6fd1ff4
Merge branch 'dev' into master
chenriksson Sep 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NuGet.Server/Controllers/PackagesODataController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ protected PackagesODataController(IServiceResolver serviceResolver)
// Exposed through ordinary Web API route. Bypasses OData pipeline.
public async Task<HttpResponseMessage> ClearCache(CancellationToken token)
{
if (RequestContext.IsLocal)
if (RequestContext.IsLocal || ServiceResolver.Current.Resolve<ISettingsProvider>().GetBoolSetting("allowRemoteCacheManagement", false))
{
await _serverRepository.ClearCacheAsync(token);
return CreateStringResponse(HttpStatusCode.OK, "Server cache has been cleared.");
Expand Down
5 changes: 5 additions & 0 deletions src/NuGet.Server/Core/DefaultServiceResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ public object Resolve(Type type)
return _packageAuthenticationService;
}

if (type == typeof(ISettingsProvider))
{
return _settingsProvider;
}

return null;
}

Expand Down
2 changes: 1 addition & 1 deletion src/NuGet.Server/Default.aspx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<% } %>
</fieldset>

<% if (Request.IsLocal) { %>
<% if (Request.IsLocal || ServiceResolver.Current.Resolve<NuGet.Server.Core.Infrastructure.ISettingsProvider>().GetBoolSetting("allowRemoteCacheManagement", false)) { %>
<fieldset style="width:800px">
<legend><strong>Adding packages</strong></legend>

Expand Down
11 changes: 1 addition & 10 deletions src/NuGet.Server/NuGet.Server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,16 +174,7 @@
<VisualStudio>
<FlavorProperties GUID="{349c5851-65df-11da-9384-00065b846f21}">
<WebProjectProperties>
<UseIIS>True</UseIIS>
<AutoAssignPort>True</AutoAssignPort>
<DevelopmentServerPort>1425</DevelopmentServerPort>
<DevelopmentServerVPath>/</DevelopmentServerVPath>
<IISUrl>http://localhost:40221/</IISUrl>
<NTLMAuthentication>False</NTLMAuthentication>
<UseCustomServer>False</UseCustomServer>
<CustomServerUrl>
</CustomServerUrl>
<SaveServerSettingsInUserFile>False</SaveServerSettingsInUserFile>
<SaveServerSettingsInUserFile>True</SaveServerSettingsInUserFile>
</WebProjectProperties>
</FlavorProperties>
</VisualStudio>
Expand Down
2 changes: 2 additions & 0 deletions src/NuGet.Server/Web.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@
on a fixed 1-hour interval.
-->
<add key="enableFileSystemMonitoring" value="true" />
<!--Set allowRemoteCacheManagement to true to enable the "clear cache" and other cache operations initiated via requests originating from remote hosts.-->
<add key="allowRemoteCacheManagement" value="true" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would set default to false, to match the default in code and existing behavior.

</appSettings>
<!--
For a description of web.config changes see http://go.microsoft.com/fwlink/?LinkId=235367.
Expand Down