Appended allowRemoteCacheManagement key into web.config to allow remote cache management (clear cache). #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ReleasePrep 2018-02-26]Merge dev into master
…te cache management.
…low remote cache management." This reverts commit daf5b2d.
…te cache management.
|
|
…te cache management.
…low remote cache management." This reverts commit daf5b2d.
…te cache management.
chenriksson
suggested changes
Aug 24, 2018
There was a problem hiding this comment.
@ezverev Sorry for the delay in response!
If you can address the web.config feedback, I think we should merge your contribution. Thanks!
src/NuGet.Server/Web.config
Outdated
| @@ -69,6 +69,8 @@ | |||
| on a fixed 1-hour interval. | |||
| --> | |||
| <add key="enableFileSystemMonitoring" value="true" /> | |||
| <!--Set allowRemoteCacheManagement to true to enable the "clear cache" and other cache operations initiated via requests originating from remote hosts.--> | |||
| <add key="allowRemoteCacheManagement" value="true" /> | |||
There was a problem hiding this comment.
I would set default to false, to match the default in code and existing behavior.
|
I've made the requested change. |
chenriksson
approved these changes
Aug 28, 2018
|
Verified - build 39649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In smaller companies it is important to have an ability to enforce quick nuget updates. I suggest allowing the cache management be available for remote users via config.