Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

Add a new version to the help #373

Merged
merged 8 commits into from
Jul 4, 2022
Merged

Add a new version to the help #373

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db537cc
Add a new version to the help
jornbh May 4, 2022
4364983
Merge branch 'master' of https://github.com/NordicSemiconductor/pc-nr…
jornbh May 4, 2022
afc9906
Got a lot of help from Edvin, which basically solved the issue for me. 👍
jornbh May 5, 2022
b317ce4
I somehow managed to forget to add a comma after the last string
jornbh May 5, 2022
ee3445e
Merge branch 'master' of https://github.com/NordicSemiconductor/pc-nr…
jornbh Jun 29, 2022
dc5f4f4
Merge branch 'master' of https://github.com/NordicSemiconductor/pc-nr…
jornbh Jul 1, 2022
43ea731
Remove the v-s, because they were inconistent with the other values.
jornbh Jul 1, 2022
89c4d7f
Drop leading zeros
jornbh Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion nordicsemi/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,12 +537,18 @@ def pkg():
'\n|s112_nrf52_6.1.1|0xB8|'
'\n|s112_nrf52_7.0.0|0xC4|'
'\n|s112_nrf52_7.0.1|0xCD|'
'\n|s112_nrf52_v7.2.0|0x0103|'
Copy link
Contributor

@kenr kenr Jul 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested two byte values?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check whether it's correct to have this v before the version, since other lines don't have it.

'\n|s112_nrf52_v7.3.0|0x0126|'
'\n|s113_nrf52_7.0.0|0xC3|'
'\n|s113_nrf52_7.0.1|0xCC|'
'\n|s113_nrf52_v7.2.0|0x0102|'
'\n|s113_nrf52_v7.3.0|0x0125|'
'\n|s122_nrf52_v8.0.0|0x00EA|'
'\n|s122_nrf52_v8.1.1|0x0112|'
'\n|s130_nrf51_1.0.0|0x67|'
'\n|s130_nrf51_2.0.0|0x80|'
'\n|s132_nrf52_2.0.0|0x81|'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line got swapped with the line below when sorting these values.

'\n|s130_nrf51_2.0.1|0x87|'
'\n|s132_nrf52_2.0.0|0x81|'
'\n|s132_nrf52_2.0.1|0x88|'
'\n|s132_nrf52_3.0.0|0x8C|'
'\n|s132_nrf52_3.1.0|0x91|'
Expand All @@ -558,11 +564,15 @@ def pkg():
'\n|s132_nrf52_6.1.1|0xB7|'
'\n|s132_nrf52_7.0.0|0xC2|'
'\n|s132_nrf52_7.0.1|0xCB|'
'\n|s132_nrf52_v7.2.0|0x0101|'
'\n|s132_nrf52_v7.3.0|0x0124|'
'\n|s140_nrf52_6.0.0|0xA9|'
'\n|s140_nrf52_6.1.0|0xAE|'
'\n|s140_nrf52_6.1.1|0xB6|'
'\n|s140_nrf52_7.0.0|0xC1|'
'\n|s140_nrf52_7.0.1|0xCA|'
'\n|s140_nrf52_7.2.0|0x0100|'
'\n|s140_nrf52_v7.3.0|0x0123|'
'\n|s212_nrf52_6.1.1|0xBC|'
'\n|s332_nrf52_6.1.1|0xBA|'
'\n|s340_nrf52_6.1.1|0xB9|',
Expand Down