This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Add a new version to the help #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jornbh
commented
May 5, 2022
| '\n|s130_nrf51_1.0.0|0x67|' | ||
| '\n|s130_nrf51_2.0.0|0x80|' | ||
| '\n|s132_nrf52_2.0.0|0x81|' |
There was a problem hiding this comment.
This line got swapped with the line below when sorting these values.
kenr
reviewed
Jul 1, 2022
nordicsemi/__main__.py
Outdated
| @@ -537,12 +537,18 @@ def pkg(): | |||
| '\n|s112_nrf52_6.1.1|0xB8|' | |||
| '\n|s112_nrf52_7.0.0|0xC4|' | |||
| '\n|s112_nrf52_7.0.1|0xCD|' | |||
| '\n|s112_nrf52_v7.2.0|0x0103|' | |||
There was a problem hiding this comment.
Have you tested two byte values?
ghost
reviewed
Jul 1, 2022
nordicsemi/__main__.py
Outdated
| @@ -537,12 +537,18 @@ def pkg(): | |||
| '\n|s112_nrf52_6.1.1|0xB8|' | |||
| '\n|s112_nrf52_7.0.0|0xC4|' | |||
| '\n|s112_nrf52_7.0.1|0xCD|' | |||
| '\n|s112_nrf52_v7.2.0|0x0103|' | |||
There was a problem hiding this comment.
Please check whether it's correct to have this v before the version, since other lines don't have it.
ghost
previously approved these changes
Jul 1, 2022
ghost
approved these changes
Jul 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just following the instrctions from a Jira ticket. May consider adding the ID for 3.7.3 as well.