This repository was archived by the owner on Jan 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 272
Add options to configure serial update timeouts #199
Merged
bihanssen
merged 84 commits into
master
from
azanelli-actronika-dev-dfu-wait-for-board-branch
Feb 15, 2019
Merged
Add options to configure serial update timeouts #199
bihanssen
merged 84 commits into
master
from
azanelli-actronika-dev-dfu-wait-for-board-branch
Feb 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we already wait in read operation.
as it already respond, so there is no need to continue to send ping.
and add option to set them. By default the update now wait 30 seconds before timeout because of a no ping response. This enable user to run the update utility before going in dfu state as the timing can be quite short with some DFU settings. For instance, if the only way to trigger the update is during the boot process after a reset with a short inactivity timer.
NCP-1945: Adding new generated dfu_cc_pb2.py with addition of new FwType: EXTERNAL_APPLICATION NCP-NONE: Moving OpCode Init to top-level
…a flag type variable NCP-NONE: Fixing bool expression
NRF-1904: Fixing boolean error for --external_app
NRFFOSDK-12436: Making Zigbee packages external-app only
…vice or --bootloader for Zigbee FW upgrade
…e-ota-fw-version (optional)
… small images read, 260KB => 640 bytes) NRFFOSDK-12346: Cleanup of the OTA_file class generation
…ause that is the implementation in the bootloader
Makes most of the channel parameters for the ANT dfu transport configurable from the command line.
A platform check should be performed before using the ant dfu command. Only a python 32bit interpreter on windows is supported as the antlib package depends on precompiled windows 32bit libraries.
Development changes on the dependent antlib package applied.
Co-Authored-By: aledsi <[email protected]>
Co-Authored-By: aledsi <[email protected]>
Co-Authored-By: aledsi <[email protected]>
Co-Authored-By: aledsi <[email protected]>
For the ant dlls to be included with the generated exe bundle it is necessary to specify them with the binaries directive
* Added device lister * Dfu trigger loads libusb1 libraries * Libusb is bundled with nrfutil * Checking if COM ports are open * Handling missing trigger interface * Port for USB device will be automatically detected when a serial number if provided. * Libusb error access is handled * Bootloader trigger check * Updated documentation on dfu using device serial number * __is_device_in_bootloader_mode returns true for jlink devices * Syntax style fix * Dfu trigger checks if Python is running 32 bit or 64 bit before attempting to load libusb binaries
With debug-mode switch it shall be possible to skip version checking. When required-flag is set this will not work as intended.
Update click requirement to v7.* Use compatibility operator ~= to avoid unintentional major version upgrade Rename usb_serial to usb-serial in readme. As of Click v7.0 the default behavior is to use hyphen as separator for command names.
Adding version range specifiers to guard against unintended and in worst case incompatible changes in the dependency modules.
* Perform address argument validation, using regexp * Add click unit tests for address validation
Move macOS dylib to 64bit folder
* Dll loading with pyinstaller fixed * Cross platform paths * Pyinstall bundling for MacOS fixes
chunfantasy
approved these changes
Feb 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bencefr
approved these changes
Feb 15, 2019
bihanssen
added a commit
that referenced
this pull request
Feb 15, 2019
* Don't sleep while between device ping when doing UART serial update as we already wait in read operation. * Stop pinging target when it responds while performing UART serial update as it already respond, so there is no need to continue to send ping. * Distinguish serial port timeout and ping timeout and add option to set them. By default the update now wait 30 seconds before timeout because of a no ping response. This enable user to run the update utility before going in dfu state as the timing can be quite short with some DFU settings. For instance, if the only way to trigger the update is during the boot process after a reset with a short inactivity timer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges #146 by @azanelli-actronika.
Sepearate PR due to merge conflicts with master.
Closes #146.