This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Add options to configure serial update timeouts #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 17, 2018 12:29
as we already wait in read operation.
as it already respond, so there is no need to continue to send ping.
and add option to set them. By default the update now wait 30 seconds before timeout because of a no ping response. This enable user to run the update utility before going in dfu state as the timing can be quite short with some DFU settings. For instance, if the only way to trigger the update is during the boot process after a reset with a short inactivity timer.
|
@azanelli-actronika thanks for the contribution. The changes have been merged via PR 199. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch mainly add option to configure the serial UART update timeout values. In my application, the only way to update the firmware is to reset the board and trigger the update during the bootloader stage. As I have set a short inactivity timer for dfu to ensure quick boot (200 ms), I had to modify the nrfutil to wait a longer time for board to be ready and to reduce the ping interval, that's why i add the option to configure these timeout.
Please note that I only add these options to the UART update method and not for the USB serial as the latter doesn't ping the target.
Feel free to comment.