Python: several fixes #28884
Merged
Python: several fixes #28884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Rebased and added. Thanks @jluttine |
FRidh
added
the
1.severity: mass-rebuild
FRidh
added a commit
to FRidh/nixpkgs
that referenced
this pull request
Sep 6, 2017
Python: several fixes (cherry picked from commit 67651d8)
|
This PR introduces evaluation errors into Nixpkgs: |
|
Oh, thanks. The fix dcbf59d |
copumpkin
reviewed
Sep 8, 2017
| @@ -19,4 +19,7 @@ buildPythonPackage rec { | |||
| postPatch = '' | |||
| substituteInPlace requirements.txt --replace "argparse" "" | |||
| ''; | |||
|
|
|||
| # Requires a bunch of new packages | |||
| meta.broken = true; | |||
There was a problem hiding this comment.
How did this one become broken when it worked before?
|
As usual: other package upgrades. Someone should go through the whole Oslo
thing if they want to keep it alive.
…On Sep 8, 2017 18:35, "Daniel Peebles" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/development/python-modules/oslo-config/default.nix
<#28884 (comment)>:
> @@ -19,4 +19,7 @@ buildPythonPackage rec {
postPatch = ''
substituteInPlace requirements.txt --replace "argparse" ""
'';
+
+ # Requires a bunch of new packages
+ meta.broken = true;
How did this one become broken when it worked before?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#28884 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACB873shQKdMMoooDAt-0WGCckWHPv-5ks5sgWzugaJpZM4PK192>
.
|
dotlambda
reviewed
Feb 10, 2018
| sha256 = "15yxz8d70iy1b1x6gd7spvblq0mjxjardl4vnaqasxafzc069zca"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ pbr python_mimeparse extras lxml unittest2 ]; |
There was a problem hiding this comment.
@FRidh Do you know why this depends on lxml? I can't find it in https://github.com/testing-cabal/testtools/blob/b4d158ab8aff96c4212d49b3f0d2c3001682c3c9/requirements.txt
There was a problem hiding this comment.
No idea, it was there already. Let's throw it out.
There was a problem hiding this comment.
I'll try enabling the tests as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)