-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: flexget: 2.10.40 -> 2.10.82 #28615
Conversation
@Mic92, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @infinisil and @tari to be potential reviewers. |
dfaf880
to
8730f9d
Compare
There are a lot of Python package updates on staging, so let's wait till staging is merged into master. |
I will also merge this one into staging first. |
@@ -15,15 +15,15 @@ | |||
}: | |||
|
|||
let | |||
jinja = jinja2.override rec { | |||
jinja = jinja2.overrideDerivation (old: rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check out the new overridePythonAttrs
. It overrides the call to buildPythonPackage
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this recommend inside python-modules? Also after all ansible should not be here after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding within a derivation should indeed be prevented inside python-packages.nix
to avoid multiple versions. But when you do override, I think overridePythonAttrs
is typically most useful now.
I agree that ansible
doesn't belong there, and if it would be moved the overriding wouldn't be an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have move out ansible out of pythonPackages
. In the documentation it is explained, how one can get a new python derivation with overridePythonAttrs
, how does this work with buildPythonApplication
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly the same.
5ba5c49
to
9957c66
Compare
82fa0b3
to
7e016e8
Compare
@tari if you spot some mistakes, please let me know. |
ae01232
to
0e491a5
Compare
Thanks for also looking at this. A minor improvement would be to use |
Can you merge my changes into #28884 |
@Mic92 I've merged the changes in my branch so closing this. |
I got
with #28884. |
Ahh, we need to unpin some dependencies. 5db60db |
Motivation for this change
needs more testing what dependent packages are broken by the update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)