-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc-wrapper: disable response files for ccache #178280
Conversation
The problem is that the ccache wrapper does not work with response files (it seems like the fd doesn't survive after exec in the makeWrapper wrapper).
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1089 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM and this fixes the issue.
I'm inclined to merge this.
Pinged ccache maintainers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thanks for the ping @Atemu! This LGTM!!
Oh wait I just noticed that it looks like ccache fixed parsing response files in v4.6.1: https://ccache.dev/releasenotes.html#_build_improvements_6 - this probably isn't needed anymore. |
It wasn't working for me and the ccache version is 4.8 in my local tree I cherry-picked this onto. |
Ok, thanks! Just wanted to check first if ccache added supported for it in the meantime. |
@kira-bruneau Btw, where did you see clang response files being supported in that changelog? |
Oh it was |
The problem is that the ccache wrapper does not work with response
files (it seems like the fd doesn't survive after exec in the
makeWrapper wrapper).
Description of changes
Resolves: #119779
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes