Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: biome #384795

Closed
3 tasks done
ElrohirGT opened this issue Feb 24, 2025 · 2 comments · Fixed by #384904
Closed
3 tasks done

Build failure: biome #384795

ElrohirGT opened this issue Feb 24, 2025 · 2 comments · Fixed by #384904
Labels
0.kind: build failure A package fails to build

Comments

@ElrohirGT
Copy link
Contributor

Nixpkgs version

  • Unstable (25.05)

Steps to reproduce

Copy the following flake file:

{
  description = "A very basic flake";

  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";
  };

  outputs = {
    self,
    nixpkgs,
  }: {
    packages.x86_64-linux.default = let
      pkgs = import nixpkgs {system = "x86_64-linux";};
    in
      pkgs.mkShell {
        packages = [pkgs.biome];
      };
  };
}

The flake.lock is (latest unstable):

{
  "nodes": {
    "nixpkgs": {
      "locked": {
        "lastModified": 1740367490,
        "narHash": "sha256-WGaHVAjcrv+Cun7zPlI41SerRtfknGQap281+AakSAw=",
        "owner": "nixos",
        "repo": "nixpkgs",
        "rev": "0196c0175e9191c474c26ab5548db27ef5d34b05",
        "type": "github"
      },
      "original": {
        "owner": "nixos",
        "ref": "nixos-unstable",
        "repo": "nixpkgs",
        "type": "github"
      }
    },
    "root": {
      "inputs": {
        "nixpkgs": "nixpkgs"
      }
    }
  },
  "root": "root",
  "version": 7
}

and run nix develop. It'l take some time to compile (rust btw) but then the checkPhase fails... I'm not 100% confident this issue is the fault of the package maintainers but still, having an issue here to track the build failure seems appropiate.

Can Hydra reproduce this build failure?

Please select the Hydra Status.

Link to Hydra build job

No response

Relevant log output

error: builder for '/nix/store/npjdf9faiaz3hv633fs1axd7sjv90m6p-biome-1.9.4.drv' failed with exit code 101;
       last 25 log lines:
       >     8     8 │   "linter": {
       >     9       │-    "ignore": ["**/build"],
       >           9 │+    "ignore": ["**<TEMP_DIR>"],
       >    10    10 │     "enabled": true,
       >    11    11 │     "rules": {
       >    12    12 │       "recommended": true
       >    13    13 │     }
       > ────────────┴───────────────────────────────────────────────────────────────────
       > To update snapshots run `cargo insta review`
       > Stopped on the first failure. Run `cargo insta test` to run all snapshots.
       > thread 'commands::format::should_format_files_in_folders_ignored_by_linter' panicked at /build/biome-1.9.4-vendor/insta-1.40.0/src/runtime.rs:548:9:
       > snapshot assertion for 'should_format_files_in_folders_ignored_by_linter' failed in line 423
       >
       >
       > failures:
       >     commands::check::print_json
       >     commands::check::print_json_pretty
       >     commands::explain::explain_logs
       >     commands::format::print_json
       >     commands::format::print_json_pretty
       >     commands::format::should_format_files_in_folders_ignored_by_linter
       >
       > test result: FAILED. 534 passed; 6 failed; 3 ignored; 0 measured; 0 filtered out; finished in 0.68s
       >
       > error: test failed, to rerun pass `-p biome_cli --test main`
       For full logs, run 'nix log /nix/store/npjdf9faiaz3hv633fs1axd7sjv90m6p-biome-1.9.4.drv'.


Output of: `nix log /nix/store/npjdf9faiaz3hv633fs1axd7sjv90m6p-biome-1.9.4.drv`

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/62vh9j2s178k7shl2wjwlj8jq78lm0db-source
source root is source
Executing cargoSetupPostUnpackHook
Finished cargoSetupPostUnpackHook
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Executing cargoSetupPostPatchHook
Validating consistency between /build/source/Cargo.lock and /build/biome-1.9.4-vendor/Cargo.lock
Finished cargoSetupPostPatchHook
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing cargoBuildHook
cargoBuildHook flags: -j 12 --target x86_64-unknown-linux-gnu --offline --profile release -p=biome_cli
�[1m�[32m   Compiling�[0m proc-macro2 v1.0.86
�[1m�[32m   Compiling�[0m unicode-ident v1.0.8
�[1m�[32m   Compiling�[0m memchr v2.7.4
�[1m�[32m   Compiling�[0m autocfg v1.1.0
�[1m�[32m   Compiling�[0m serde v1.0.210
�[1m�[32m   Compiling�[0m once_cell v1.20.0
�[1m�[32m   Compiling�[0m equivalent v1.0.1
�[1m�[32m   Compiling�[0m hashbrown v0.15.0
�[1m�[32m   Compiling�[0m serde_json v1.0.128
�[1m�[32m   Compiling�[0m itoa v1.0.6
�[1m�[32m   Compiling�[0m ryu v1.0.13
�[1m�[32m   Compiling�[0m libc v0.2.159
�[1m�[32m   Compiling�[0m pin-project-lite v0.2.13
�[1m�[32m   Compiling�[0m log v0.4.20
�[1m�[32m   Compiling�[0m syn v1.0.109
�[1m�[32m   Compiling�[0m schemars v0.8.21
�[1m�[32m   Compiling�[0m tracing-core v0.1.32
�[1m�[32m   Compiling�[0m hashbrown v0.12.3
�[1m�[32m   Compiling�[0m dyn-clone v1.0.11
�[1m�[32m   Compiling�[0m hashbrown v0.14.5
�[1m�[32m   Compiling�[0m unicode-segmentation v1.12.0
�[1m�[32m   Compiling�[0m rustc-hash v1.1.0
�[1m�[32m   Compiling�[0m cfg-if v1.0.0
�[1m�[32m   Compiling�[0m countme v3.0.1
�[1m�[32m   Compiling�[0m version_check v0.9.4
�[1m�[32m   Compiling�[0m indexmap v1.9.3
�[1m�[32m   Compiling�[0m crossbeam-utils v0.8.19
�[1m�[32m   Compiling�[0m biome_string_case v0.5.7 (/build/source/crates/biome_string_case)
�[1m�[32m   Compiling�[0m thiserror v1.0.63
�[1m�[32m   Compiling�[0m proc-macro-error-attr v1.0.4
�[1m�[32m   Compiling�[0m similar v2.6.0
�[1m�[32m   Compiling�[0m proc-macro-error v1.0.4
�[1m�[32m   Compiling�[0m lock_api v0.4.11
�[1m�[32m   Compiling�[0m parking_lot_core v0.9.9
�[1m�[32m   Compiling�[0m bitflags v1.3.2
�[1m�[32m   Compiling�[0m quote v1.0.37
�[1m�[32m   Compiling�[0m io-lifetimes v1.0.6
�[1m�[32m   Compiling�[0m scopeguard v1.1.0
�[1m�[32m   Compiling�[0m rustix v0.37.7
�[1m�[32m   Compiling�[0m unicode-width v0.1.12
�[1m�[32m   Compiling�[0m linux-raw-sys v0.3.8
�[1m�[32m   Compiling�[0m syn v2.0.77
�[1m�[32m   Compiling�[0m adler2 v2.0.0
�[1m�[32m   Compiling�[0m gimli v0.31.0
�[1m�[32m   Compiling�[0m termcolor v1.4.1
�[1m�[32m   Compiling�[0m biome_diagnostics_categories v0.5.7 (/build/source/crates/biome_diagnostics_categories)
�[1m�[32m   Compiling�[0m is_ci v1.1.1
�[1m�[32m   Compiling�[0m miniz_oxide v0.8.0
�[1m�[32m   Compiling�[0m object v0.36.0
�[1m�[32m   Compiling�[0m rustc-demangle v0.1.24

Additional context

No response

System metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.77, NixOS, 24.11 (Vicuna), 24.11.20250217.c618e28`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.12`
 - nixpkgs: `/nix/store/mma8n3yfap91nw44hfcfyl18ffv5hl68-source`

Notify maintainers

@figsoda
@isabelroses


Note for maintainers: Please tag this issue in your pull request description. (i.e. Resolves #ISSUE.)

I assert that this issue is relevant for Nixpkgs

Is this issue important to you?

Add a 👍 reaction to issues you find important.

@ElrohirGT ElrohirGT added the 0.kind: build failure A package fails to build label Feb 24, 2025
iguntur added a commit to iguntur/vnix that referenced this issue Feb 24, 2025
@DOD-101
Copy link
Contributor

DOD-101 commented Feb 24, 2025

I spent some time looking into this:

It seems that the cargo insta snapshot tests fail only when cargo test is run with --release (as is the case when building for nixpkgs).

This behavior persists on the following branches / tags:

  • main

  • cli/v1.9.5-nightly.81fdedb

  • cli/v1.9.4 (the current version used by nixpkgs)

I'm not sure what to do about this. It might be a good idea to create an Issue upstream and/or to skip tests in the meantime. (not sure about that, though).

Fair Warning: I might be missing something here. These are just my results pocking and prodding and at the upstream tests and the nixpkgs code. (for about 1-2h)

Hopefully this helps.

@isabelroses
Copy link
Member

I spent some time looking into this:

It seems that the cargo insta snapshot tests fail only when cargo test is run with --release (as is the case when building for nixpkgs).

This behavior persists on the following branches / tags:

  • main
  • cli/v1.9.5-nightly.81fdedb
  • cli/v1.9.4 (the current version used by nixpkgs)

I'm not sure what to do about this. It might be a good idea to create an Issue upstream and/or to skip tests in the meantime. (not sure about that, though).

Fair Warning: I might be missing something here. These are just my results pocking and prodding and at the upstream tests and the nixpkgs code. (for about 1-2h)

Hopefully this helps.

Thanks for looking into this, I found something similar in my research but nowhere near as in-depth. I plan to just disable the tests until a fix is made upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants