Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 When running cargo test --release tests fail #5197

Open
1 task done
isabelroses opened this issue Feb 24, 2025 · 2 comments
Open
1 task done

🐛 When running cargo test --release tests fail #5197

isabelroses opened this issue Feb 24, 2025 · 2 comments
Labels
S-Needs triage Status: this issue needs to be triaged

Comments

@isabelroses
Copy link

Environment information

Not really relevant but


CLI:
  Version:                      0.0.0
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         xterm-256color
  JS_RUNTIME_VERSION:           unset
  JS_RUNTIME_NAME:              unset
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         /home/isabel/dev/forks/biome/biome.json
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  true

Workspace:
  Open Documents:               0

What happened?

  1. checkout main
  2. attempt to run cargo test run -p biome_cli --no-fail-fast --release
  3. observe build failure

Expected result

The build succedes

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@isabelroses isabelroses added the S-Needs triage Status: this issue needs to be triaged label Feb 24, 2025
@isabelroses
Copy link
Author

See also downstream failure NixOS/nixpkgs#384795 (comment)

@ematipico
Copy link
Member

I read the comment in the upstream issue, and I believe the failure might be expected.

The failure comes from our test suite for the CLI, where we do some snapshot testing. These tests are redacted to avoid differences in CI: execution times, temporary folders, Windows folders. These redactions are based on some heuristics that might not work in some cases. (Production build maybe, running tests with a production build, etc.).

My advice would be to use the insta environment variable to update the snapshots so the tests pass: https://insta.rs/docs/advanced/#controlling-snapshot-updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Needs triage Status: this issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants