Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPDEV-101357] Remove docker support #664

Merged
merged 11 commits into from
May 29, 2024
Merged

[CPDEV-101357] Remove docker support #664

merged 11 commits into from
May 29, 2024

Conversation

iagusev
Copy link
Collaborator

@iagusev iagusev commented May 23, 2024 •
edited by ilia1243
Loading

Description

  • 1.23 version support was removed.
  • docker support was removed.

Solution

  • migrate_cri.py procedure was removed completely.
  • test_migrate_cri.py was removed completely.
  • migrate_cri procedure was removed from documentation.
  • 1.23 version was removed from kubernetes_versions.yaml.
  • docker was removed from globals.yaml and defaults.yaml.
  • docker usages were removed from procedures.

How to apply

Run kubemarine migrate_kubemarine --force-apply reinstall_etcdctl

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Docker cases were modified or removed.

Ivan Gusev added 2 commits May 15, 2024 12:43
Docker support removal.
e117b3e 
1.23 and 1.24 versions were removed from kubernetes_versions.yaml.
docker mentions removed from procedures.
migrate_cri.py procedure was removed completely, test_migrate_cri.py was removed as well.
Unit tests changes.
e759c1e 
Tests were changed due to docker deprecation.
@iagusev iagusev requested review from ilia1243 and Imadzuma May 23, 2024 07:22
@koryaga koryaga requested review from alexarefev and n549 May 23, 2024 09:03
@vlar0816
Copy link
Contributor

This table also needs to be updated - Installation.md#supported-versions

@iagusev iagusev marked this pull request as draft May 27, 2024 09:04
Ivan Gusev added 3 commits May 27, 2024 16:35
docker removal.
574a3e6 
docker was removed from backup.pym check_iaas.py and check_paas.py
fix linter error
ea9fe67
fix linter error
a46c3c5
@iagusev iagusev marked this pull request as ready for review May 28, 2024 06:28
@ilia1243 ilia1243 force-pushed the remove_docker_support branch 2 times, most recently from 297e70a to b46087f Compare May 28, 2024 17:20
@ilia1243 ilia1243 force-pushed the remove_docker_support branch from b46087f to 0159ad1 Compare May 28, 2024 17:42
@ilia1243 ilia1243 requested a review from disa1217 May 28, 2024 17:42
@koryaga koryaga merged commit bd0012d into main May 29, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koryaga koryaga koryaga approved these changes

@ilia1243 ilia1243 Awaiting requested review from ilia1243

@Imadzuma Imadzuma Awaiting requested review from Imadzuma

@alexarefev alexarefev Awaiting requested review from alexarefev

@n549 n549 Awaiting requested review from n549

@disa1217 disa1217 Awaiting requested review from disa1217

Assignees

@koryaga koryaga

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iagusev @vlar0816 @koryaga @ilia1243