-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MANOPD-81794 JSON schema implementation #302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33d9d9b
to
652ad36
Compare
858cf42
to
8cddf31
Compare
4a7345d
to
34b8dba
Compare
6db87e3
to
e952039
Compare
koryaga
approved these changes
Jan 19, 2023
dmyar21
pushed a commit
that referenced
this pull request
Jan 19, 2023
* Inventory JSON schema implementation * Auto-update license header * Build Binary via Docker * Custom variables and ignore errors * Added forgotten additional parameters to remove_node.json * Add description for the variables and sections * Fix coredns schema to allow to turn any setting off * Add forgotten Kubemarine custom params for coredns. * Add unit tests, fix examples and minor bugs * Auto-update license header * Update Installation.md * Update Maintenance.md * Update add_node.json * Update backup.json * Update cert_renew.json * Update cluster.json * Fixed error messages * Update add_node.json * Update cluster.json * Minor fixes in schemas and validation * Unify getting of Kubemarine version * Minor outdated validation fix * Upload binary artifact during build * Fix schema for calico BGP asNumber * Fix unit tests verifying examples * Fix CI extended config Co-authored-by: ilia1243 <[email protected]> Co-authored-by: shmo1218 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #304
Solution
jsonschema
and JSON schemas to validate inventory file of cluster and of each Kubemarine procedure.The JSON schemas are used during KubeMarine run and can be used in IDEs that support YAML validation, i. e. PyCharm, Visual Studio Code.
values
section to hold custom variables to be used in Jinja2 templates.--ignore-schema-errors
that continues work of Kubemarine even if validation is failed. The option is to be removed in next release.node.name
parameter optional.How to apply
It is necessary to verify inventory file:
values
section. Usages of the variables should be adopted correspondingly. See LimitationsTest Cases
TestCase 1
Test Configuration:
Steps:
cluster.yaml
contain sections or variables that are not known to KubeMarine.Results:
TestCase 2
Test Configuration:
Steps:
Results:
TestCase 3
Test Configuration:
Steps:
cluster.yaml
or inventory file for any procedure contain sections or variables that are not known to KubeMarine.--ignore-schema-errors
option.Results:
Regression Testing
Checklist
Unit tests
manage_pss
procedure enrichment and finalization.