refactor: main release/21.08.0 merge #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: spelling, save API key not safe it
fix: add prom-stack.yml to binaries
fix: pass version release to dockerfile
fix: add harvest.cue in binaries
Thanks to Jeff Asher for sharing these! Fabricpool isn't working in any of these yet.
Thanks to Jeff Asher for sharing these!
* fix: units, duplicate graphs, use more flexible variables * fix: titles, missing read-write ops for nfsv4 * fix: nfs version to variable
fix: units, duplicate graphs, use more flexible variables (#454)
If the schedule is once a week, the first time autosupport runs, it instead runs after two weeks.
time |---X----f----y----|
^ ^
| |
now -- ---- future
That's because when a task is created and added to the schedule at X, a time in the future is calculated (current time + 1 week), at f.
Later, when a go routine checks if the future task is due to run, it determines that by calculating: one week - time.Since(f), but since f is already a week in the future. The task won't run until y, which is two weeks after X was scheduled.
The fix: when the task is scheduled, schedule it at the current time instead of current time + 1 week.
fix: first autosupport runs after delay
…elease-merge # Conflicts: # jenkins/artifacts/JenkinWorkflow
rahulguptajss
requested review from
cdurai-netapp,
cgrinds,
Hardikl and
vgratian
as code owners
rahulguptajss
changed the title
Thanks to Jeff Asher for reporting this
fix: typo in nfsv4 template causes mislabeling
Hardikl
previously approved these changes
Aug 31, 2021
|
we need to include last 3 commits: |
* feat: svm details dashboard Thanks to Jeff Asher for sharing! * fix: units, duplicate graphs, svm label in query Co-authored-by: Vachagan Gratian <[email protected]>
* docs: update changelog for 21.08
* feat: node details dashboard with edits Thanks to Jeff Asher for sharing these! * fix: units, labels, legends and aggregation in some graphs * refactor: Details dashboards should be named same * feat: node-details dashboard remove fabricpool Co-authored-by: Vachagan Gratian <[email protected]> Co-authored-by: rahulg2 <[email protected]>
|
merged all pending ones. ready for review. |
cgrinds
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.