fix: units, duplicate graphs, use more flexible variables #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgratian
requested review from
cdurai-netapp,
cgrinds,
Hardikl and
rahulguptajss
as code owners
Hardikl
reviewed
Aug 26, 2021
| @@ -193,21 +195,22 @@ | |||
| "text": {}, | |||
| "textMode": "auto" | |||
| }, | |||
| "pluginVersion": "8.0.6", | |||
| "pluginVersion": "7.5.6", | |||
| } | ||
| }, | ||
| "pluginVersion": "8.0.6", | ||
| "targets": [ | ||
| { | ||
| "exemplar": false, | ||
| "expr": "svm_nfs_read_avg_latency{datacenter=\"$Datacenter\",cluster=\"$Cluster\",svm=~\"$SVM\",nfsv=\"v3\"} / 1000", | ||
| "expr": "avg(svm_nfs_read_avg_latency{datacenter=\"$Datacenter\",cluster=\"$Cluster\",svm=~\"$SVM\",nfsv=\"v3\"})", |
There was a problem hiding this comment.
thanks a lot for noticing this!
| "hide": false, | ||
| "interval": "", | ||
| "legendFormat": "Read", | ||
| "refId": "Read Latency" | ||
| }, | ||
| { | ||
| "exemplar": false, | ||
| "expr": "svm_nfs_write_avg_latency{datacenter=\"$Datacenter\",cluster=\"$Cluster\",svm=~\"$SVM\",nfsv=\"v3\"} / 1000", | ||
| "expr": "avg(svm_nfs_write_avg_latency{datacenter=\"$Datacenter\",cluster=\"$Cluster\",svm=~\"$SVM\",nfsv=\"v3\"})", |
cgrinds
approved these changes
Aug 26, 2021
Hardikl
approved these changes
Aug 27, 2021
cgrinds
pushed a commit
that referenced
this pull request
Aug 27, 2021
* fix: units, duplicate graphs, use more flexible variables * fix: titles, missing read-write ops for nfsv4 * fix: nfs version to variable
rahulguptajss
added a commit
that referenced
this pull request
Aug 27, 2021
fix: units, duplicate graphs, use more flexible variables (#454)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed a number of issues mentioned in my comment here