Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate network dashboards #1314

Merged
merged 8 commits into from
Sep 28, 2022
+2,613 −8,026
Merged

fix: remove duplicate network dashboards #1314

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e32fce9
fix: remove duplicate network dashboards
rahulguptajss Sep 27, 2022
0b42371
fix: remove duplicate network dashboards
rahulguptajss Sep 27, 2022
f75c764
fix: remove duplicate network dashboards
rahulguptajss Sep 27, 2022
8752b3f
fix: remove duplicate network dashboards
rahulguptajss Sep 27, 2022
6a076c1
fix: remove duplicate network dashboards
rahulguptajss Sep 27, 2022
c8335b5
fix: remove duplicate network dashboards
rahulguptajss Sep 27, 2022
4770cf0
fix: add comments
rahulguptajss Sep 27, 2022
4253343
feat: addressed review comments
rahulguptajss Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: addressed review comments
  • Loading branch information
@rahulguptajss
rahulguptajss committed Sep 28, 2022
commit 4253343c8ed43d57ea38f3fde627eb6f2895ed98
4 changes: 2 additions & 2 deletions cmd/collectors/restperf/plugins/nic/nic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ func (me *Nic) Run(data *matrix.Matrix) ([]*matrix.Matrix, error) {
var speed, base int
var s string
var err error

s = instance.GetLabel("speed")
if s != "" {
if s = instance.GetLabel("speed"); strings.HasSuffix(s, "M") {
if strings.HasSuffix(s, "M") {
base, err = strconv.Atoi(strings.TrimSuffix(s, "M"))
if err != nil {
me.Logger.Warn().Msgf("convert speed [%s]", s)
Expand Down