Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate network dashboards #1314

Merged
merged 8 commits into from
Sep 28, 2022
Merged

fix: remove duplicate network dashboards #1314

merged 8 commits into from
Sep 28, 2022

Conversation

rahulguptajss
Copy link
Contributor

Fixes #1306

@rahulguptajss
Copy link
Contributor Author

Changes as below.

1: Removed dashboard harvest_dashboard_nvme_fc.json
2: Added nvmf panel in harvest_dashboard_network_detail.json
3: Removed speed * 8 from ethernet table in harvest_dashboard_network_detail.json as it was not done in harvest_dashboard_nvme_fc.json. Removing this multiplication also seem to have solved issue #1251. Let's discuss this and if it is needed, we should do it in template plugins.

cgrinds
cgrinds previously approved these changes Sep 27, 2022
Hardikl
Hardikl previously approved these changes Sep 28, 2022
cmd/collectors/restperf/plugins/nic/nic.go Show resolved Hide resolved
@rahulguptajss rahulguptajss dismissed stale reviews from Hardikl and cgrinds via 4253343 September 28, 2022 12:25
@Hardikl Hardikl merged commit 6b45932 into main Sep 28, 2022
@Hardikl Hardikl deleted the rg2-network branch September 28, 2022 12:57
@Hardikl Hardikl linked an issue Sep 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants