Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-demo): fix baseHref in angular.json file #479

Conversation

christophercr
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The baseHref was removed from the angular.json file of the showcase due to PRs #471 and #477. However the showcase is broken since Angular requires a baseHref to be defined.

What is the new behavior?

Showcase correctly running since the baseHref is defined in the angular.json file.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

@christophercr christophercr merged commit d2c36cd into NationalBankBelgium:master Jul 3, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.447% when pulling 2a36276 on christophercr:feature/showcase-basehref-fix into 6fc4fb3 on NationalBankBelgium:master.

@christophercr christophercr deleted the feature/showcase-basehref-fix branch July 3, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants