Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-demo): revert PR #471. Adapt baseHref/deployUrl via Node script to fix Showcase publication on GitHub pages #477

Conversation

christophercr
Copy link
Collaborator

ISSUES CLOSED: 466

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Although the baseHref can be dynamically changed via the Angular APP_BASE_HREF provider, the CSS and other assets are imported from the wrong folder since the deployUrl is used during the bundle building by Wepack to generate such imports. The issue is that the deployUrl cannot be defined dynamically.

Issue Number: #466

What is the new behavior?

Reverted the changes made in #471 related to the definiton of the APP_BASE_HREF as an environment provider.

The final baseHref and deploy URL are adapted via a Node script before the showcase is copied to the GH-Pages branch.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

…ly via Node script to fix Showcase when published in GitHub pages

ISSUES CLOSED: 466
@christophercr christophercr changed the title fix(stark-demo): revert PR #471. Adapt baseHref/deployUrl automatically via Node script to fix Showcase when published in GitHub pages fix(stark-demo): revert PR #471. Adapt baseHref/deployUrl via Node script to fix Showcase publication on GitHub pages Jul 2, 2018
@christophercr christophercr added this to the 10.0.0-alpha.4 milestone Jul 2, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.46% when pulling f9dadfd on christophercr:feature/showcase-base-href into 946b925 on NationalBankBelgium:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 95.46% when pulling f9dadfd on christophercr:feature/showcase-base-href into 946b925 on NationalBankBelgium:master.

@dsebastien dsebastien merged commit 6fc4fb3 into NationalBankBelgium:master Jul 2, 2018
@christophercr christophercr deleted the feature/showcase-base-href branch July 4, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants