fix(stark-demo): revert PR #471. Adapt baseHref/deployUrl via Node script to fix Showcase publication on GitHub pages #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: 466
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Although the baseHref can be dynamically changed via the Angular APP_BASE_HREF provider, the CSS and other assets are imported from the wrong folder since the deployUrl is used during the bundle building by Wepack to generate such imports. The issue is that the deployUrl cannot be defined dynamically.
Issue Number: #466
What is the new behavior?
Reverted the changes made in #471 related to the definiton of the APP_BASE_HREF as an environment provider.
The final baseHref and deploy URL are adapted via a Node script before the showcase is copied to the GH-Pages branch.
Does this PR introduce a breaking change?