-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch 'branch-24.02' into main #10383
Conversation
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
Signed-off-by: Peixin Li <[email protected]>
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
* use fixed seed for test_from_json_struct_decimal * signoff Signed-off-by: Andy Grove <[email protected]> --------- Signed-off-by: Andy Grove <[email protected]>
…" (NVIDIA#10355) This reverts commit 6723a68. Signed-off-by: Bobby Wang <[email protected]>
* xfail test * signoff Signed-off-by: Andy Grove <[email protected]> --------- Signed-off-by: Andy Grove <[email protected]>
…IA#10309) * add custom 404 page Signed-off-by: liyuan <[email protected]> * Update .github/404.html Co-authored-by: Gera Shegalov <[email protected]> * test markdownlink checker Signed-off-by: liyuan <[email protected]> * check all links Signed-off-by: liyuan <[email protected]> * fix all dead links Signed-off-by: liyuan <[email protected]> * revert markdown link checker config files after fix all dead links Signed-off-by: liyuan <[email protected]> * enable all links checking as discussed in NVIDIA#10322 Signed-off-by: liyuan <[email protected]> * we already support zstd orc and parquet write, fix NVIDIA#10365 Signed-off-by: liyuan <[email protected]> --------- Signed-off-by: liyuan <[email protected]> Co-authored-by: Gera Shegalov <[email protected]>
Signed-off-by: Tim Liu <[email protected]>
This PR is not the final merge to main change. Draft the PR for the in-advance review purpose NOTE: There are still some open PRs targeting 24.02, will do the final merge after they get merged. https://github.com/NVIDIA/spark-rapids/pulls?q=is%3Apr+is%3Aopen+base%3Abranch-24.02+ |
@@ -125,7 +125,7 @@ Generated on 2024-01-31 | |||
|[#10123](https://github.com/NVIDIA/spark-rapids/pull/10123)|Change version to v23.12.1 [skip ci]| | |||
|[#10122](https://github.com/NVIDIA/spark-rapids/pull/10122)|Init changelog for v23.12.1 [skip ci]| | |||
|[#10121](https://github.com/NVIDIA/spark-rapids/pull/10121)|[DOC] update download page for db hot fix [skip ci]| | |||
|[#10116](https://github.com/NVIDIA/spark-rapids/pull/10116)|Upgrade to 23.12.1| | |||
|[#10116](https://github.com/NVIDIA/spark-rapids/pull/10116)|Upgrade to 23.12.1-SNPASHOT| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo that's not in branch-24.02? Curious how this change happened since it should just be a merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! thanks @jlowe
I found the root cause, that's my fault:
On dev branch-24.02 it is 23.12.1-SNAPSHOT
: https://github.com/NVIDIA/spark-rapids/blob/branch-24.02/CHANGELOG.md
But, on main branch, I replaced all 23.12.1-SNAPSHOT
to 23.12.1
, where I should NOT modify it in CHANGELOG.md file :
e83c1c1
So we should keep 23.12.1-SNPASHOT
in CHANGELOG.md here, to make it the same as what dev branch is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dev branch does not have 23.12.1-SNPASHOT, it has 23.12.1-SNAPSHOT. I'm curious how SNAPSHOT became SNPASHOT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, sorry, this is a typo when I fixed merge conflicts to main from dev branch.
Compared to the dev branch, there is only version change to 24.02.0
from 24.02.0-SNAPSHOT
let me fix the typo
Signed-off-by: Tim Liu <[email protected]>
This reverts commit 19cd490. Create a change targeting to branch-24.02
Shall we update e.g. shuffle-plugin/pom.xml on shuffle-plugin/pom.xml changed |
Yes. If we are not simply merging but also modifying with this PR, any files modified instead of simply merged need to have updated copyrights. |
Signed-off-by: Tim Liu <[email protected]>
Close this PR, it's replaced by #10395 |
Merge branch 'branch-24.02' into main
Change version to 24.02.0
Note: please merge this change with "Create a merge commit"