Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'branch-24.02' into main #10383

Closed
wants to merge 235 commits into from
Closed

Conversation

NvTimLiu
Copy link
Collaborator

@NvTimLiu NvTimLiu commented Feb 6, 2024

Merge branch 'branch-24.02' into main

Change version to 24.02.0

Note: please merge this change with "Create a merge commit"

nvauto and others added 30 commits November 14, 2023 14:14
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
[auto-merge] branch-23.12 to branch-24.02 [skip ci] [bot]
andygrove and others added 6 commits February 1, 2024 08:46
* use fixed seed for test_from_json_struct_decimal

* signoff

Signed-off-by: Andy Grove <[email protected]>

---------

Signed-off-by: Andy Grove <[email protected]>
* xfail test

* signoff

Signed-off-by: Andy Grove <[email protected]>

---------

Signed-off-by: Andy Grove <[email protected]>
…IA#10309)

* add custom 404 page

Signed-off-by: liyuan <[email protected]>

* Update .github/404.html

Co-authored-by: Gera Shegalov <[email protected]>

* test markdownlink checker

Signed-off-by: liyuan <[email protected]>

* check all links

Signed-off-by: liyuan <[email protected]>

* fix all dead links

Signed-off-by: liyuan <[email protected]>

* revert markdown link checker config files after fix all dead links

Signed-off-by: liyuan <[email protected]>

* enable all links checking as discussed in NVIDIA#10322

Signed-off-by: liyuan <[email protected]>

* we already support zstd orc and parquet write, fix NVIDIA#10365

Signed-off-by: liyuan <[email protected]>

---------

Signed-off-by: liyuan <[email protected]>
Co-authored-by: Gera Shegalov <[email protected]>
@NvTimLiu NvTimLiu added documentation Improvements or additions to documentation build Related to CI / CD or cleanly building labels Feb 6, 2024
@NvTimLiu NvTimLiu self-assigned this Feb 6, 2024
@NvTimLiu NvTimLiu marked this pull request as draft February 6, 2024 11:42
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Feb 6, 2024

This PR is not the final merge to main change.

Draft the PR for the in-advance review purpose

NOTE: There are still some open PRs targeting 24.02, will do the final merge after they get merged.

https://github.com/NVIDIA/spark-rapids/pulls?q=is%3Apr+is%3Aopen+base%3Abranch-24.02+

@@ -125,7 +125,7 @@ Generated on 2024-01-31
|[#10123](https://github.com/NVIDIA/spark-rapids/pull/10123)|Change version to v23.12.1 [skip ci]|
|[#10122](https://github.com/NVIDIA/spark-rapids/pull/10122)|Init changelog for v23.12.1 [skip ci]|
|[#10121](https://github.com/NVIDIA/spark-rapids/pull/10121)|[DOC] update download page for db hot fix [skip ci]|
|[#10116](https://github.com/NVIDIA/spark-rapids/pull/10116)|Upgrade to 23.12.1|
|[#10116](https://github.com/NVIDIA/spark-rapids/pull/10116)|Upgrade to 23.12.1-SNPASHOT|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo that's not in branch-24.02? Curious how this change happened since it should just be a merge.

Copy link
Collaborator Author

@NvTimLiu NvTimLiu Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thanks @jlowe

I found the root cause, that's my fault:

On dev branch-24.02 it is 23.12.1-SNAPSHOT : https://github.com/NVIDIA/spark-rapids/blob/branch-24.02/CHANGELOG.md

But, on main branch, I replaced all 23.12.1-SNAPSHOT to 23.12.1, where I should NOT modify it in CHANGELOG.md file :
e83c1c1

So we should keep 23.12.1-SNPASHOT in CHANGELOG.md here, to make it the same as what dev branch is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev branch does not have 23.12.1-SNPASHOT, it has 23.12.1-SNAPSHOT. I'm curious how SNAPSHOT became SNPASHOT.

Copy link
Collaborator Author

@NvTimLiu NvTimLiu Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, sorry, this is a typo when I fixed merge conflicts to main from dev branch.

Compared to the dev branch, there is only version change to 24.02.0 from 24.02.0-SNAPSHOT

let me fix the typo

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Feb 7, 2024

Oh I should create a PR targeting to branch-24.02 for : 19cd490

Let me revert it from merge-to-main, create a new PR for branch-24.02:

#10389

This reverts commit 19cd490.

Create a change targeting to branch-24.02
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Feb 7, 2024

Shall we update -2024 copyright targeting to main, as we change version to 24.02.0 from 24.02.0-SNAPSHOT branch-24.02(on which copyright is up to 2.23)? @jlowe @sameerz @GaryShen2008 @tgravescs @revans2

e.g. shuffle-plugin/pom.xml on branch-24.02 : https://github.com/NVIDIA/spark-rapids/blob/branch-24.02/shuffle-plugin/pom.xml#L3

shuffle-plugin/pom.xml changedmerge-to-main : f56520c#diff-c29b084f7d961795298e283df6dcc8b6a5a549abe6d1153347faa414e932acdb

@jlowe
Copy link
Contributor

jlowe commented Feb 7, 2024

Shall we update -2024 copyright targeting to main, as we change version to 24.02.0 from 24.02.0-SNAPSHOT

Yes. If we are not simply merging but also modifying with this PR, any files modified instead of simply merged need to have updated copyrights.

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Feb 8, 2024

This commit history of merge-to-main got messed up with additional commits:

19cd490

7610623

735a06f

and fix typo

I'd like to drop this one, and create a clean and new merge-to-main PR instead.

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Feb 8, 2024

Close this PR, it's replaced by #10395

@NvTimLiu NvTimLiu closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.