-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] update dead link in UDF doc #10322
Comments
The reason why markdown link checker did not find it is because we just checked the modified files. |
There are 3 pages have dead links in total: |
This seems like a flawed approach. It will detect bad links added to the modified files, but it cannot catch the problem of moving/removing a target of a link somewhere else that was not modified (and should have been). How long does it actually take to run the full scan? Our CI build already takes 2+ hours, so I'd be shocked if link checking was the limiting factor for PR workflows. If it's still deemed too expensive to run the full check per PR, we would want to run this regularly (nightly?) to check for bad links. |
I think we need to run the full checks either nightly or CI. There are huge possibility that the existing doc might have broken links. |
It will take 5-10 minutes for each commit to check all links, if the CI is two hours then checking all links has very little impact. Will enable all checks. |
* add custom 404 page Signed-off-by: liyuan <[email protected]> * Update .github/404.html Co-authored-by: Gera Shegalov <[email protected]> * test markdownlink checker Signed-off-by: liyuan <[email protected]> * check all links Signed-off-by: liyuan <[email protected]> * fix all dead links Signed-off-by: liyuan <[email protected]> * revert markdown link checker config files after fix all dead links Signed-off-by: liyuan <[email protected]> * enable all links checking as discussed in #10322 Signed-off-by: liyuan <[email protected]> * we already support zstd orc and parquet write, fix #10365 Signed-off-by: liyuan <[email protected]> --------- Signed-off-by: liyuan <[email protected]> Co-authored-by: Gera Shegalov <[email protected]>
We already migrate getting started docs to new pages, so we need to fix all dead link in gh-page branch and original docs. And we need to find out why markdown-link checker does not find it.
One Frequently Asked Questions entry dead link in UDF doc,
The text was updated successfully, but these errors were encountered: