add in-flight icing products to inline post #568
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
SamuelTrahanNOAA
changed the title
|
@SamuelTrahanNOAA What's the status of this PR? I hasn't been updated for 3 months. |
34 tasks
|
This PR is scheduled to be merged soon and nobody has reviewed it. |
DusanJovic-NOAA
approved these changes
Mar 16, 2023
WenMeng-NOAA
approved these changes
Mar 16, 2023
|
This was merged as part of #628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add in-flight icing products to the inline post.
A full description of the new feature, and status of the draft, can be found in this merged UPP PR:
NOAA-EMC/UPP#536
Issue(s) addressed
ufs-community/ufs-weather-model#1647
Testing
How were these changes tested? Results for unaffected tests do not change. New fields are created with valid content, unless library is absent, then the fields have missing values.
What compilers / HPCs was it tested with? Tests were run on hera and jet, but the target machine is WCOSS2; the library has restricted access and won't be available elsewhere.
Are the changes covered by regression tests? Yes.
Dependencies
NOAA-EMC/UPP#655