Addresses a11y labels error issue #1609 #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barugonman
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
approved these changes
Jan 31, 2025
|
Thanks @duranb , I did a bit of a skim and can't see a way to pass the one value to the other, but if someone can figure it out we can fix it later. Other examples I've looked at have had similar redundancy. |
AaronPlave
approved these changes
Jan 31, 2025
barugonman
force-pushed
the
a11y_labels_task1
branch
from
08e337c to
6a6f3b4
Compare
barugonman
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of a set of PRs fixing a11y errors. Two 'missing label' errors fixed by adding aria-label with content matching 'placeholder'.
See #1609 on how to reproduce the issue using WAVE plugin.